Skip to content

Conversation

@miquelbeltran
Copy link
Member

@miquelbeltran miquelbeltran commented Feb 1, 2021

Work required to do: #50

@miquelbeltran miquelbeltran mentioned this pull request Feb 1, 2021
11 tasks
@miquelbeltran miquelbeltran force-pushed the ci-beta-enable branch 2 times, most recently from a867711 to 3292d62 Compare February 1, 2021 19:54
@miquelbeltran miquelbeltran changed the title Enable channel beta on CI [wip] Enable channel beta on CI Feb 1, 2021
@miquelbeltran
Copy link
Member Author

The following packages have analyze issues:

    └> FAILED (in 4 packages)
       └> android_alarm_manager_example (with exit code 1)
       └> android_alarm_manager_plus (with exit code 1)
       └> device_info_example (with exit code 1)
       └> device_info_plus (with exit code 1)

There's also issues with the build_examples_dart step, which used build aot command that does no longer exist, I will try to find a replacement for it but build apk is veeeeery slow.

@miquelbeltran miquelbeltran changed the title [wip] Enable channel beta on CI Enable channel beta on CI Feb 2, 2021
await subscription.cancel();
exit(result == 'pass' ? 0 : 1);
final Map<String, dynamic> result = jsonDecode(data);
exit(result['result'] == 'true' ? 0 : 1);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is the same that the flutter/plugins project is doing

Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@miquelbeltran miquelbeltran merged commit 06fdf27 into main Feb 2, 2021
@miquelbeltran miquelbeltran deleted the ci-beta-enable branch February 2, 2021 08:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants