Skip to content

Enable channel beta on CI #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miquelbeltran merged 5 commits into from
Feb 2, 2021
Merged

Enable channel beta on CI #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a7dece
enable channel beta on CI
miquelbeltran Feb 1, 2021
d341754
replace build aot by assemble #89
miquelbeltran Feb 1, 2021
5fcdf31
run build bundle
miquelbeltran Feb 2, 2021
b684c6c
imported changes from https://github.com/flutter/plugins/commit/89b6e…
miquelbeltran Feb 2, 2021
3055aa0
'onError' is deprecated
miquelbeltran Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/all_plugins.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
with:
fetch-depth: 0
- name: 'Install Flutter'
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh beta
- name: 'Install Tools'
run: |
./.github/workflows/scripts/install-tools.sh
Expand All @@ -43,7 +43,7 @@ jobs:
with:
fetch-depth: 0
- name: 'Install Flutter'
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh beta
- name: 'Install Tools'
run: |
./.github/workflows/scripts/install-tools.sh
Expand Down Expand Up @@ -75,15 +75,15 @@ jobs:
with:
fetch-depth: 0
- name: 'Install Flutter'
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh beta
- name: 'Install Tools'
run: ./.github/workflows/scripts/install-tools.sh
- name: 'Bootstrap Workspace'
run: melos bootstrap
- name: 'Build Example Snapshots'
run: |
melos exec -c 1 --scope="*example*" -- \
flutter build aot
flutter build bundle
test:
runs-on: ubuntu-latest
timeout-minutes: 15
Expand All @@ -92,7 +92,7 @@ jobs:
with:
fetch-depth: 0
- name: 'Install Flutter'
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh beta
- name: 'Install Tools'
run: ./.github/workflows/scripts/install-tools.sh
- name: 'Bootstrap Workspace'
Expand Down
38 changes: 7 additions & 31 deletions ...s/android_alarm_manager_plus/example/test_driver/android_alarm_manager_plus_e2e_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,42 +3,18 @@
// BSD-style license that can be found in the LICENSE file.

import 'dart:async';
import 'dart:convert';
import 'dart:io';

import 'package:flutter_driver/flutter_driver.dart';
import 'package:vm_service_client/vm_service_client.dart';

Future<StreamSubscription<VMIsolateRef>> resumeIsolatesOnPause(
FlutterDriver driver) async {
final vm = await driver.serviceClient.getVM();
print('for isolates');
for (final isolateRef in vm.isolates) {
final isolate = await isolateRef.load();
if (isolate.isPaused) {
print('isolate.resume');
await isolate.resume();
}
}
return driver.serviceClient.onIsolateRunnable
.asBroadcastStream()
.listen((VMIsolateRef isolateRef) async {
print('onIsolateRunnable');
final isolate = await isolateRef.load();
if (isolate.isPaused) {
print('isolate.resume');
await isolate.resume();
}
});
}

Future<void> main() async {
final driver = await FlutterDriver.connect();
// flutter drive causes isolates to be paused on spawn. The background isolate
// for this plugin will need to be resumed for the test to pass.
final subscription = await resumeIsolatesOnPause(driver);
final result =
await driver.requestData(null, timeout: const Duration(minutes: 5));
final data = await driver.requestData(
null,
timeout: const Duration(minutes: 1),
);
await driver.close();
await subscription.cancel();
exit(result == 'pass' ? 0 : 1);
final Map<String, dynamic> result = jsonDecode(data);
exit(result['result'] == 'true' ? 0 : 1);
Copy link
Member Author

@miquelbeltran miquelbeltran Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is the same that the flutter/plugins project is doing

}
4 changes: 2 additions & 2 deletions packages/device_info_plus/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ import 'package:flutter/services.dart';
import 'package:device_info_plus/device_info_plus.dart';

void main() {
runZoned(() {
runZonedGuarded(() {
runApp(MyApp());
}, onError: (dynamic error, dynamic stack) {
}, (dynamic error, dynamic stack) {
print(error);
print(stack);
});
Expand Down