Prevent Flux from overriding Flagger managed objects #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
force-pushed
the
prevent-flux-overrides
branch
3 times, most recently
from
9a973f6
to
322285e
Compare
Codecov Report
@@ Coverage Diff @@
## main #1049 +/- ##
=======================================
Coverage 57.15% 57.15%
=======================================
Files 76 76
Lines 6138 6139 +1
=======================================
+ Hits 3508 3509 +1
Misses 2103 2103
Partials 527 527
Continue to review full report at Codecov.
|
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
prevent-flux-overrides
branch
from
322285e
to
45ecaa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotate the routing objects managed by Flagger (Kubernetes services, virtual services, ingresses, etc) to prevent Flux from overriding them. This change requires Flux 0.22.0 or newer.
This allows Flux users to add Flagger Canaries to their repos without having to delete any existing Kubernetes Services. Users that deploy apps with HelmReleases they must remove the Kubernetes Services from their charts, because Flux, when used with Helm, is not capable of ignoring changes in-cluster.