Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gateway API as a provider #1108

Merged
merged 11 commits into from
Mar 14, 2022
Merged

Conversation

aryan9600
Copy link
Member

@aryan9600 aryan9600 commented Feb 14, 2022

This PR adds support for Gateway API (v1alpha2) as a provider. It supports progressive traffic shifting, A/B testing and blue/green deployments.

Fix: #1089

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022

Codecov Report

Merging #1108 (065ee82) into main (ae6a683) will decrease coverage by 0.51%.
The diff coverage is 42.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
- Coverage   57.29%   56.77%   -0.52%     
==========================================
  Files          78       79       +1     
  Lines        6343     6582     +239     
==========================================
+ Hits         3634     3737     +103     
- Misses       2166     2291     +125     
- Partials      543      554      +11     
Impacted Files Coverage Δ
pkg/metrics/observers/factory.go 0.00% <0.00%> (ø)
pkg/router/factory.go 0.00% <0.00%> (ø)
pkg/router/gateway_api.go 44.01% <44.01%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6a683...065ee82. Read the comment docs.

@stefanprodan
Copy link
Member

@aryan9600 can you please signoff your commits and add e2e tests for the Gateway API with Contour.

pkg/router/factory.go Show resolved Hide resolved
kustomize/gatewayapi/patch.yaml Outdated Show resolved Hide resolved
@aryan9600 aryan9600 force-pushed the aryan9600/gateway-api branch 4 times, most recently from c5d5962 to 125ffb9 Compare February 18, 2022 12:21
@stefanprodan stefanprodan marked this pull request as ready for review March 9, 2022 10:10
@stefanprodan stefanprodan added the kind/feature Feature request label Mar 9, 2022
aryan9600 and others added 9 commits March 10, 2022 16:54
Adds Gateway API as a provider for progressive traffic shifting, A/B
testing and Blue-Green testing. Adds a new field in the Canary
`spec.service.gatewayRefs` which specifies the Gateway that Flagger
should use.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
@aryan9600 aryan9600 force-pushed the aryan9600/gateway-api branch 2 times, most recently from 21da642 to 55c1760 Compare March 10, 2022 12:43
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Awesome contribution! Thanks @aryan9600 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Gateway APIs
3 participants