Add support for session affinity during weighted routing with Istio #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 54.45% // Head: 54.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
==========================================
+ Coverage 54.45% 54.72% +0.27%
==========================================
Files 81 81
Lines 9408 9515 +107
==========================================
+ Hits 5123 5207 +84
- Misses 3663 3682 +19
- Partials 622 626 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
stefanprodan
requested changes
Nov 9, 2022
Add `.spec.analysis.sessionAffinity` to configure session affinity for weighted routing. Add support for session affinity in the Istio router, using the `Set-Cookie` and `Cookie` headers. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
sticky-istio
branch
from
07299e3
to
8705c8e
Compare
aryan9600
force-pushed
the
sticky-istio
branch
2 times, most recently
from
21afb7c
to
3f9960e
Compare
aryan9600
force-pushed
the
sticky-istio
branch
from
3f9960e
to
b095713
Compare
stefanprodan
approved these changes
Nov 15, 2022
stefanprodan
added
the
kind/enhancement
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
sticky-istio
branch
from
b095713
to
d16c969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for session affinity/sticky sessions during weighted routing with Istio, i.e. when a user is routed to the canary deployment, all subsequent requests from that user will hit the canary deployments, even though weighted routing is active.
This feature can be enabled by specifying a
.spec.analysis.sessionAffinty.cookieName. This value combined with a random sequence (<cookie-name>: <random-sequence>) is used as the value of theSet-Cookieheader, and then all requests' headers that match against this value are sent to the canary deployment. Users can also specify.spec.analysis.sessionAffinity.maxAgeto configure the lifetime of the cookie being set.Fixes: #1198, #1232