Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement metric range validation #424

Merged
merged 5 commits into from
Feb 9, 2020
Merged

Implement metric range validation #424

merged 5 commits into from
Feb 9, 2020

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Feb 8, 2020 •
edited
Loading

This PR adds range validation for the canary analysis metrics. The thresholdRange takes precedence over threshold when both are specified.

Changes:

  • add CanaryThresholdRange type to Canary API
  • add optional thresholdRange field to the analysis metric object
  • implement min/max metric result validation
  • add e2e and unit tests for metric checks
  • improve Canary CRD schema

Range validation example:

  canaryAnalysis:
    metrics:
      - name: "database connections"
        interval: 1m
        templateRef:
          name: db-con
        thresholdRange:
          min: 2
          max: 120

Fix: #125
Fix: #387

@stefanprodan
Implement metric threshold range
de03d49 
- add CanaryThresholdRange type to Canary API
- add optional thresholdRange field to the analysis metric object
- implement min/max metric result validation
- thresholdRange takes precedence over threshold when both are specified
@stefanprodan
Improve Canary CRD schema validation
228954b 
- add thresholdRange validation
- add Kubernetes Kind validation for target, autoscaler and ingress
- add validation for webhook metadata map[string]string
- add missing Istio types to schema validation
@stefanprodan
Add metric threshold range to e2e tests
e4e92b3
@stefanprodan
Add metrics to controller tests
8f99e58 
Fix: #387
@stefanprodan stefanprodan merged commit ea4a849 into master Feb 9, 2020
@stefanprodan stefanprodan deleted the threshold-range branch February 9, 2020 08:19
@stefanprodan stefanprodan mentioned this pull request Mar 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cover metrics.Observer code in scheduler tests Range validation for Custom Metrics
1 participant
@stefanprodan