Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement metric range validation #424

Merged
merged 5 commits into from
Feb 9, 2020
Merged

Implement metric range validation #424

merged 5 commits into from
Feb 9, 2020

Commits on Feb 8, 2020

  1. Implement metric threshold range 

    - add CanaryThresholdRange type to Canary API
- add optional thresholdRange field to the analysis metric object
- implement min/max metric result validation
- thresholdRange takes precedence over threshold when both are specified
    @stefanprodan
    stefanprodan committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    de03d49 View commit details
    Browse the repository at this point in the history

  2. Improve Canary CRD schema validation 

    - add thresholdRange validation
- add Kubernetes Kind validation for target, autoscaler and ingress
- add validation for webhook metadata map[string]string
- add missing Istio types to schema validation
    @stefanprodan
    stefanprodan committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    228954b View commit details
    Browse the repository at this point in the history

  3. Add metric threshold range to e2e tests

    @stefanprodan
    stefanprodan committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    e4e92b3 View commit details
    Browse the repository at this point in the history

  4. Add metrics to controller tests 

    Fix: #387
    @stefanprodan
    stefanprodan committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    8f99e58 View commit details
    Browse the repository at this point in the history

  5. Add metric templates to controller tests

    @stefanprodan
    stefanprodan committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    5c479d9 View commit details
    Browse the repository at this point in the history