feat: Support daemonset target kind #455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #345
this PR adds support for daemonset target
Although there is still much of codes that can be shared among Deployments and DaemonSets (for example, test fixtures have lines of duplicated codes), i intentionally left as it is and just copied and pasted for daemonset support so that there would be less influence on existing code bases for deployment/service.
notes
ignore progressDeadlineSeconds for daemonset since currently there's noDaemonSetCondition
types in k8s to check the progress as Deployment does.anyway, thanks for maintaining this awesome project 👍