Set GOMAXPROCS and GOMEMLIMIT using downward API
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
force-pushed
the
GOMAXPROCS
branch
from
221bcc7 to
6275bbb
Compare
stefanprodan
changed the title
GOMAXPROCS to 2GOMAXPROCS and GOMEMLIMIT using downward API
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
GOMAXPROCS
branch
from
6275bbb to
4629b83
Compare
|
After running the benchmarks a couple of times, my conclusion is that is safe to add the env vars to the main distribution. There is no regression in terms of reconciliation speed. |
|
Included in #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test if setting
GOMAXPROCSandGOMEMLIMITimpacts the benchmark results.xref: fluxcd/source-controller#1443