Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GOMAXPROCS and GOMEMLIMIT to all Flux controllers #4717

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

hawwwdi
Copy link
Contributor

@hawwwdi hawwwdi commented Apr 11, 2024

if applied, set GOMAXPROCS and GOMEMLIMIT for all controllers based on container resources which leads to reduce throttling and better performance.

ref: fluxcd/source-controller#1443
ref: fluxcd/flux-benchmark#5

if applied, set GOMAXPROCS and GOMEMLIMIT for all controllers based on container resources which leads to reduce throttling and better performance

Signed-off-by: Hadi Abbasi <hawwwdi@gmail.com>
@stefanprodan stefanprodan changed the title Set GOMAXPROCS and GOMEMLIMIT vars Set GOMAXPROCS and GOMEMLIMIT to all Flux controllers Apr 11, 2024
@stefanprodan
Copy link
Member

@hawwwdi have you've seen any improvements to CPU throttling on your cluster?

@stefanprodan stefanprodan added the area/install Install and uninstall related issues and pull requests label Apr 11, 2024
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan mentioned this pull request Apr 12, 2024
59 tasks
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hawwwdi

@stefanprodan stefanprodan added the area/bootstrap Bootstrap related issues and pull requests label Apr 12, 2024
@stefanprodan stefanprodan merged commit e573800 into fluxcd:main Apr 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants