-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Doesn't update & trigger deployment of HelmRelease #2067
Comments
AFAIK you have to provide the image name in the If you list the images using In other words, I would expect the automation to start working if you change your apiVersion: flux.weave.works/v1beta1
kind: HelmRelease
metadata:
name: myapp
namespace: myapp-ns
annotations:
flux.weave.works/automated: "true"
flux.weave.works/tag.chart-image: glob:master-*
spec:
releaseName: myapp
chart:
git: ssh://git@marcel-repo.com/myapp.git
path: helm/myapp
ref: master
values:
image:
repository: marcel-registry.com/<image-name>
tag: master-3d30e14fd7 You can read more about upgrading HelmReleases in the Helm Integration Docs. |
Thanks for your comment @Suigi, support like this from the community is highly appreciated 🥇 @dminca the comment from Suigi sums it all up pretty well, Flux needs both the |
@Suigi you are right, sorry about that, was a typo on my side. Not an image name, actually I was referring to the registry URI there in the If you craft the To overcome this, I've just put the registry + label in the same variable in values:
image: marcel-registry.com/myapp:master-3d30e14fd7 Otherwise it's not triggering the deploy. |
@dminca for portability I would personally split it in two keys, Flux will be able to detect In addition; are you okay with me closing the issue as it looks like it's working for you now? |
I've already addressed this issue to @stefanprodan at KubeCon. I wouldn't close it until there's this thing written in the docs, that it requires the full registry url and image label in the same variable; otherwise more people will raise it and you'll end up with dupes 😅 |
@dminca would the note added in the PR linked to this issue have helped you? |
Thank you 👍 |
Update readme to address regression bug that doesn't automatically trigger HelmRelease deployment if -> the full Docker Registry URL + image name + image label are not provided in a Helm Chart as a single variable (not splitted) -> which in turn is read by the HelmRelease Resolves: Related: fluxcd#2067 Signed-off-by: Daniel Andrei Minca <mandrei17@gmail.com>
Describe the bug
Regression bug: Flux is not able to match the RegEx pattern of the
HelmRelease
image label, thus not triggering the update (in git repo) & deployment of theHelmRelease
.To Reproduce
Steps to reproduce the behaviour:
0. Given a Helm Chart with the following
values.yaml
file:HelmRelease
with the following valuesHelmRelease
actions not firingRegEx pattern mismatch
thrown)Expected behavior
Flux detected a new image in the registry and triggered an update of the image label (in git repo) and triggered a deployment of the
HelmRelease
Logs
Additional context
Add any other context about the problem here, e.g
1.12.2
0.9.2
v1.11.7
Atlassian Bitbucket
AWS ECR
The text was updated successfully, but these errors were encountered: