Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

update Helm docs with latest behaviour #2089

Closed
wants to merge 1 commit into from

Conversation

dminca
Copy link

@dminca dminca commented May 23, 2019

Update readme to address regression bug that doesn't automatically
trigger HelmRelease deployment if
-> the full Docker Registry URL + image name + image label are not provided
in a Helm Chart as a single variable (not splitted)
-> which in turn is read by the HelmRelease

Resolves:
Related: #2067
Signed-off-by: Daniel Andrei Minca

Update readme to address regression bug that doesn't automatically
trigger HelmRelease deployment if
-> the full Docker Registry URL + image name + image label are not provided
  in a Helm Chart as a single variable (not splitted)
-> which in turn is read by the HelmRelease

Resolves:
Related: fluxcd#2067
Signed-off-by: Daniel Andrei Minca <mandrei17@gmail.com>
@hiddeco
Copy link
Member

hiddeco commented May 24, 2019

The split format should work fine, the issue with the format in #2067 is that

image:
  registry: marcel-registry.com/myapp
  tag: master-3d30e14fd7

should be

image:
  repository: marcel-registry.com/myapp
  tag: master-3d30e14fd7

as documented here.

@dminca
Copy link
Author

dminca commented May 26, 2019

Ok, now it makes sense. I'll test and if it doesn't work out well I'll reopen this one.

Thanks 👍

@dminca dminca closed this May 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants