Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark suspended resource as not ready #507

Closed
3 of 4 tasks
hiddeco opened this issue Nov 25, 2020 · 0 comments · Fixed by #512
Closed
3 of 4 tasks

Do not mark suspended resource as not ready #507

hiddeco opened this issue Nov 25, 2020 · 0 comments · Fixed by #512

Comments

@hiddeco
Copy link
Member

hiddeco commented Nov 25, 2020

At present the controllers mark a resource with a Ready==False state when a user defines the resource as suspended using .spec.suspend.

Given the aim of this value is to pause all reconciliation actions, this behavior is not accurate to the goal of the field. We must simply stop reconciling and observing state, and leave any previous observed state untouched as a "freeze in time".

To still make the state visible to the user, we must add an addition printer column that shows the .spec.suspend state of the resource (example here: fluxcd/helm-controller#162), and a column to the flux get [source] commands.

  • helm-controller
  • source-controller
  • kustomize-controler
  • add "suspended" column to flux get [source] commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant