Do not mark suspended resource as not ready #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a resource is marked as suspended we should not perform any reconciliation action for the resource at all. This includes updating the status of the resource to a `Ready==False` state, as this is not an accurate representation of the resource's state: we have been told to no longer look at it and with that our last observation freezes in time. Resource deletions are the sole exception to actions (not) being performed, as we are duty-bound to remove our finalizer from the resource to make a deletion succeed. To make the suspend state still visible to the user, a column has been added to the Custom Resource Definition which prints the `.spec.suspend` of every HelmRelease. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
suspend-refactor
branch
from
46ad1c5 to
5f2f9aa
Compare
hiddeco
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a resource is marked as suspended we should not perform any
reconciliation action for the resource at all.
This includes updating the status of the resource to a
Ready==Falsestate, as this is not an accurate representation ofthe resource's state: we have been told to no longer look at it
and with that our last observation freezes in time.
Resource deletions are the sole exception to actions (not) being
performed, as we are duty-bound to remove our finalizer from the
resource to make a deletion succeed.
To make the suspend state still visible to the user, a column has
been added to the Custom Resource Definition which prints the
.spec.suspendof every HelmRelease.Ref: fluxcd/flux2#507