Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace kubectl with Go server-side apply #1885

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Replace kubectl with Go server-side apply #1885

merged 1 commit into from
Oct 6, 2021

Conversation

stefanprodan
Copy link
Member

This PR replaces kubectl apply shell execs with Go code based on fluxcd/pkg#152.

Followup of: fluxcd/kustomize-controller#426

⚠️ This PR is made against the ssa branch which will be used to collect all SSA related changes.

@stefanprodan stefanprodan added enhancement New feature or request area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests labels Oct 2, 2021
@stefanprodan stefanprodan requested a review from hiddeco October 2, 2021 09:15
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @stefanprodan 🙇

@stefanprodan stefanprodan merged commit df06d4e into ssa Oct 6, 2021
@stefanprodan stefanprodan deleted the drop-kubectl branch October 6, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants