Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement server-side apply #1908

Merged
merged 7 commits into from
Oct 8, 2021
Merged

Implement server-side apply #1908

merged 7 commits into from
Oct 8, 2021

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Oct 8, 2021 •
edited
Loading

@stefanprodan stefanprodan requested a review from hiddeco October 8, 2021 12:20
@stefanprodan stefanprodan force-pushed the ssa branch 4 times, most recently from 8a4f30b to 3e41167 Compare October 8, 2021 12:25
hiddeco
hiddeco requested changes Oct 8, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1907 should pass (or be explained) before this can be merged, as it looks like the (v1beta2) kustomize-controller does not deal properly with the v1beta1 objects that are still generated by the older version of flux.

@stefanprodan stefanprodan force-pushed the ssa branch 2 times, most recently from 62c884a to 321d557 Compare October 8, 2021 16:13
@stefanprodan
Replace kubectl with Go server-side apply
83c3e8c 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Update Kubernetes version minimum requirements
4c99117 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Update kustomize-controller API to v1beta2
0b659e3 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Mark the validation arg as deprecated
fb713e9 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Remove kubectl dependency from brew and aur pkgs
f54907e 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Update kubectl to v1.22.2 in the multi-arch image
e22ad96 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Update kustomize-controller to v0.15.0
2b4d615 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan merged commit 0e74779 into main Oct 8, 2021
@stefanprodan stefanprodan deleted the ssa branch October 8, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @hiddeco