Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the possibility to ignore files with build and diff Kustomization #3763

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Add the possibility to ignore files with build and diff Kustomization #3763

merged 1 commit into from
Apr 6, 2023

Conversation

souleb
Copy link
Member

@souleb souleb commented Apr 6, 2023 •
edited by stefanprodan
Loading

If implemented, users will be able to ignore files when using build kustomization and diff kustomization using .sourceignore and ignore-paths flag.

ignore-paths accepts a comma separated list of entries that follow the .gitignore pattern format.

Fix: #3760

@stefanprodan stefanprodan added enhancement New feature or request area/diff Diff related issues and pull requests labels Apr 6, 2023
@souleb souleb changed the title Add a the possibility to ignore files with build and diff Kustomization Add the possibility to ignore files with build and diff Kustomization Apr 6, 2023
stefanprodan
stefanprodan reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also rebase

cmd/flux/build_kustomization.go Outdated Show resolved Hide resolved
cmd/flux/diff_kustomization.go Outdated Show resolved Hide resolved
@souleb
Add the possibility to ignore files with build and diff ks
b74638c 
If implemented, user will be able to ignore files when using `build
kustomization` and `diff kustomization` both with .sourceignore and
`ignore-paths` flag.

Signed-off-by: Soule BA <bah.soule@gmail.com>
stefanprodan
stefanprodan approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb 🏅

@stefanprodan stefanprodan merged commit c350e30 into fluxcd:main Apr 6, 2023
@tun0
Copy link

tun0 commented Apr 6, 2023

Awesome!

@souleb souleb deleted the feat-ignore branch April 6, 2023 10:02
This was referenced Dec 16, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/diff Diff related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional parameter for flux diff and flux build to ignore files/directories
3 participants
@souleb @tun0 @stefanprodan