Fix a silently dropping Kustomization remote resources #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allen Porter <allen.porter@gmail.com>
allenporter
force-pushed
the
flux-generator-remote
branch
from
524c620 to
99853c5
Compare
stefanprodan
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where kustomizations with remote resources are silently dropped from
flux build ks. The behavior change appears to have been introduced in fluxcd/flux2#3763 and #528 when adding filters to ignore the source path. The behavior skips urls since they don't match file paths, but that had the side effect of not including them in the generatedKustomization. This PR reverts to the old behavor of ignoring remote urls and keeping them in the kustomization -- which is fine since source ignore paths are about paths in the source tree and not remote resources.Fixes fluxcd/flux2#4146 which describes how to reproduce the issue. An example test is included that exercises the issue ensuring the remote resource is included in the filtered kustomization, though does not actually try to build a remote resource.