Optimize Kustomize post renderer and tests #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hiddeco
commented
Feb 4, 2021
hiddeco
commented
- Use constants for APIVersion and Kind in Kustomization config
- Remove redundant JSON marshal of strategic merge patches
- Factor out Kustomization build wrapper and add notes about settings
- Add tests for Kustomize post renderer
* Use constants for APIVersion and Kind in Kustomization config * Remove redundant JSON marshal of strategic merge patches * Factor out Kustomization build wrapper and add notes about settings Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
post-renderer-tests
branch
from
456d4c2 to
dcf0d93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.