Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat quoted values as string when targetPath is set #298

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

laozc
Copy link
Contributor

@laozc laozc commented Jul 17, 2021

When the values contain quoted strings, use ParseIntoString to enforce they are set as strings.
This allows a similar behavior with CLI --set-string.

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
@squaremo squaremo added area/helm Helm related issues and pull requests enhancement New feature or request labels Jul 19, 2021
@squaremo squaremo requested a review from hiddeco July 19, 2021 13:48
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🍍

Would you be able to add at least one test to

func TestHelmReleaseReconciler_composeValues(t *testing.T) {
to confirm that what you are adding here does work properly?

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
@laozc
Copy link
Contributor Author

laozc commented Jul 23, 2021

Thank you for your contribution! 🍍

Would you be able to add at least one test to

func TestHelmReleaseReconciler_composeValues(t *testing.T) {

to confirm that what you are adding here does work properly?

Sure. Done.

Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @laozc 💯

@hiddeco hiddeco merged commit 5e38727 into fluxcd:main Jul 26, 2021
@laozc laozc deleted the set-string branch August 5, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants