Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Git operations and introduce go-git support for Azure DevOps and AWS CodeCommit #451

Merged
merged 5 commits into from
Nov 2, 2022
Merged

Refactor Git operations and introduce go-git support for Azure DevOps and AWS CodeCommit #451

merged 5 commits into from
Nov 2, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Oct 27, 2022 •
edited
Loading

Changes of note:

  • Refactor reconciler to use fluxcd/pkg/git.
  • Honour the Git Implementation set on spec.gitImplementation at the GitRepository source.
  • Bump golang-with-libgit2 to v0.4.0 which bumps libgit2 to 1.5.
  • Update to fluxcd/go-git to support multi_ack and multi_ack_detailed, enabling support to Azure DevOps when using go-git.

Fixes fluxcd/pkg#245

Sanskar Jaiswal and others added 3 commits October 27, 2022 14:42
refactor reconciler to use fluxcd/pkg/git
0296f7a 
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
build: Bump golang-with-libgit2 to v0.4.0
26bd330 
The new version uses libgit2 1.5.0 and requires git2go/v34.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@aryan9600
use gitrepo implementation for git ops
7c6a117 
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@pjbgf pjbgf added the area/git Git related issues and pull requests label Oct 27, 2022
@pjbgf pjbgf added this to the GA milestone Oct 27, 2022
@pjbgf
Copy link
Member Author

pjbgf commented Oct 27, 2022

This version can be tested using the image: ghcr.io/fluxcd/image-automation-controller:rc-7369cea9

@pjbgf pjbgf mentioned this pull request Oct 27, 2022
Merged
Bump go-git to enable multi_ack
32b8e78 
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf requested a review from a team October 28, 2022 11:01
This was referenced Oct 28, 2022
Merged
Merged
Remove redundant repoAccess
b00625b 
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@hiddeco hiddeco self-requested a review November 2, 2022 10:41
@hiddeco
Copy link
Member

hiddeco commented Nov 2, 2022

DCO fails on a miss-alignment between commit author and sign-off signature (based on email address).

@pjbgf pjbgf merged commit d293039 into fluxcd:main Nov 2, 2022
@pjbgf pjbgf deleted the git-refactoring branch November 2, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/git Git related issues and pull requests
Projects
Maintainers' Focus
Status: Done
Milestone
GA
Development

Successfully merging this pull request may close these issues.

Consolidate git implementations
3 participants
@pjbgf @hiddeco @aryan9600