Add trace event type #147
Merged
Add trace event type #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traces are persisted as Kubernetes events only, usually informing about actions taken during reconciliation that are irrelevant to the alerting system. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
added
the
area/runtime
hiddeco
reviewed
Aug 26, 2021
|
@hiddeco the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traces are persisted as Kubernetes events only, usually informing about actions taken during reconciliation that are irrelevant to the alerting system.
The GitOps Toolkit reconcilers should send a single
infoevent when the reconciliation was successful and only if the reconciliation took actions (fetch new revision, change cluster state, push changes to upstream). For no-op reconciliations, the event type should be set totraceto avoid spamming the on-call teams with irrelevant alerts.