runtime/events: fix Severity validation marker value #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, run controller-gen schemapatch to evaluate all the kubebuilder markers before generating code. Signed-off-by: Sunny <darkowlzz@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
Event.Severityvalidation marker value.Also, run
controller-gen schemapatchto evaluate all the kubebuildermarkers before generating code.
NOTE: This was introduced in #147 and wasn't caught by any of the validations.
I tried using controller-gen to evaluate the markers in order to catch such issues in the
future and was able to do so using schemapatcher. Running controller-gen
schemapatch as part of generate now evaluates all the go code with kubebuilder
markers. Tested by introducing invalid marker values in
apis/kustomizeandapis/metadata.