Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Kubernetes to 1.27.2 and Kustomize to 5.0.3 #534

Merged
merged 2 commits into from
May 22, 2023
Merged

Update Kubernetes to 1.27.2 and Kustomize to 5.0.3 #534

merged 2 commits into from
May 22, 2023

Conversation

aryan9600
Copy link
Member

@aryan9600 aryan9600 commented Apr 14, 2023 •
edited
Loading

  • Bump all k8s.io packages to be up to date with Kubernetes 1.27.2
  • Bump sigs.k8s.io/kustomize packages to be up to date with Kustomize 5.0.3
  • Bump sigs.k8s.io/controller-runtime to v0.15.0-beta.0
  • Add a new util func NewDynamicRESTMapper(restConfig *rest.Config) in runtime/client for creating new RESTMapper objects.

Part of: fluxcd/flux2#3564

@hiddeco hiddeco marked this pull request as draft April 14, 2023 08:37
@hiddeco
Copy link
Member

hiddeco commented Apr 14, 2023

Converted to draft until the controller-runtime fork is replaced with official release.

@stefanprodan stefanprodan mentioned this pull request Apr 14, 2023
Closed
5 tasks
@stefanprodan stefanprodan added area/runtime Controller runtime related issues and pull requests dependencies Pull requests that update a dependency area/kustomize Kustomize related issues and pull requests labels May 3, 2023
@aryan9600 aryan9600 force-pushed the k8s-1.27 branch 3 times, most recently from b1b482b to 84249aa Compare May 4, 2023 07:24
@aryan9600 aryan9600 mentioned this pull request May 4, 2023
Merged
@stefanprodan stefanprodan changed the title Update k8s to 1.27 and kustomize to 5.0 Update Kubernetes to 1.27 and kustomize to 5.0 May 4, 2023
@stefanprodan stefanprodan changed the title Update Kubernetes to 1.27 and kustomize to 5.0 Update Kubernetes to 1.27 and Kustomize to 5.0 May 4, 2023
@stefanprodan stefanprodan marked this pull request as ready for review May 4, 2023 09:23
stefanprodan
stefanprodan approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 🎖️

stefanprodan
stefanprodan requested changes May 4, 2023
View reviewed changes
ssa/go.mod Outdated Show resolved Hide resolved
@darkowlzz
Copy link
Contributor

Is the helmtestserver package intentionally ignored from similar updates?

@aryan9600
Copy link
Member Author

Didn't notice that package as it had no direct deps to Kubernetes or Kustomize packages 😓 Let me update it as well.

@stefanprodan stefanprodan added the hold Issues and pull requests put on hold label May 4, 2023
@stefanprodan
Copy link
Member

We decided to wait for controller-runtime v0.15 release that is blocked by a regression in Kubernetes v1.27 that will be fixed in Kubernetes 1.27.2 (scheduled for 17th May).

Ref: kubernetes-sigs/controller-runtime#2297

hiddeco
hiddeco reviewed May 22, 2023
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the controller-runtime dependencies to the v0.15.0-beta.0 tag?

After discussion with @stefanprodan, we have decided to bet on this for lower level dependencies, while allowing the controllers to manually upgrade to the final release.

This would unblock the controllers from prepping in a sane way.

@aryan9600 aryan9600 requested a review from a team as a code owner May 22, 2023 11:28
@aryan9600 aryan9600 changed the title Update Kubernetes to 1.27 and Kustomize to 5.0 Update Kubernetes to 1.27.2 and Kustomize to 5.0.3 May 22, 2023
@aryan9600 aryan9600 removed the hold Issues and pull requests put on hold label May 22, 2023
@aryan9600
update k8s to 1.27.2 and kustomize to 5.0.3
2abb341 
* k8s.io/api => v0.27.2
* k8s.io/apimachinery => v0.27.2
* k8s.io/apiextensions-apiserver => v0.27.2
* k8s.io/client-go => v0.27.2
* k8s.io/component-base => v0.27.2
* sigs.k8s.io/controller-runtime => v0.15.0-beta.0
* sigs.k8s.io/kustomize/api => v0.13.4
* sigs.k8s.io/kustomize/kyaml => v0.14.2
* helm.sh/helm/v3 => v3.12.0
* github.com/onsi/gomega => v1.27.6
* github.com/go-logr/logr => v1.2.4
* github.com/prometheus/client_golang =>  v1.15.1

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@aryan9600
runtime: add util func for creating rest mapper
38d0a59 
Add a new util func `NewDynamicRESTMapper(restConfig *rest.Config)` in
`runtime/client` for creating new RESTMapper objects.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
darkowlzz
darkowlzz approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiddeco hiddeco merged commit a23fdab into main May 22, 2023
@hiddeco hiddeco deleted the k8s-1.27 branch May 22, 2023 12:50
@stefanprodan stefanprodan mentioned this pull request May 23, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

@darkowlzz darkowlzz darkowlzz approved these changes

Assignees
No one assigned
Labels
area/kustomize Kustomize related issues and pull requests area/runtime Controller runtime related issues and pull requests dependencies Pull requests that update a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aryan9600 @hiddeco @darkowlzz @stefanprodan