-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to k8s.io/ v0.27.2 #2297
Comments
log output is not a guaranteed API (xref kubernetes/kubernetes#117238 (comment))... I'd strongly suggest removing a hard dependency on a particular format and bumping the version now |
oh... I guess #2189 already bumped and this is waiting to bump again to tag a release? |
@liggitt yes. the tests failing on a specific log format are now skipped. this is just to track 0.27.2 to do another bump |
Yup. This issue is just to wait for v0.27.2 in 2 weeks. For now we also enable our unit tests again that - as of now - ensure the log format doesn't change. I think it should be a separate discussion if we want to drop the unit tests. As far as I'm aware we also don't strictly guarantee that our log output is stable, but we try to only break it when necessary to provide users some stability if possible. (But we are absolutely aware that there are no guarantees from k/k) |
In this case the trade-off for us was basically release CR v0.15.0 with a changed log format and v0.15.1 would change it back or do we delay the release until mid May. |
kubernetes:v1.27.2 is released https://github.com/kubernetes/kubernetes/releases/tag/v1.27.2 |
/reopen |
@sbueringer: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can someone please tag a new release now that this is fixed? |
Please release a new version? #2320 |
Beta tag has been published https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0-beta.0, full release is planned for next week |
Goal of this issue is to bump to v0.27.2
While bumping to v0.27.1 we had to disable unit tests that verified the correct log format of a namespaced name (#2189, test: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_controller-runtime/2189/pull-controller-runtime-test/1651556343619784704).
As part of bumping to v0.27.2 we will enable those tests again
Note: We will wait with the v0.15.0 release until we bumped to v0.27.2.
Links:
The text was updated successfully, but these errors were encountered: