Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically search upon typing #89

Closed
juliapaci opened this issue Feb 29, 2024 · 6 comments · Fixed by #93
Closed

Automatically search upon typing #89

juliapaci opened this issue Feb 29, 2024 · 6 comments · Fixed by #93
Labels
enhancement New feature or request

Comments

@juliapaci
Copy link
Contributor

The search bar should be automatically focused when typing so you don't have to manually click on it to filter out files.

@fluxxcode
Copy link
Owner

Hi, thanks for the Issue!

The feature is already planned in the following issue: #70

@crumblingstatue has already written an experimental implementation for this:
crumblingstatue@5f148ae

But I don't know what the current status is.

There are also a few points about when we want to avoid the behavior:

  • When the user presses Ctrl or Shift so that we can implement Key bindings in the future
  • When the user is already in any input field

@fluxxcode fluxxcode added the enhancement New feature or request label Feb 29, 2024
@crumblingstatue
Copy link
Contributor

But I don't know what the current status is.

It was rebased against the latest dev branch yesterday.

  • When the user presses Ctrl or Shift so that we can implement Key bindings in the future

  • When the user is already in any input field

I can try and make it fit these requirements and clean things up and open a pull request

@juliapaci
Copy link
Contributor Author

juliapaci commented Mar 1, 2024

Sorry for late reply,
is this sorta what you guys had in mind? juliapaci@2da6e0c

fixes:

and avoids:

When the user presses Ctrl or Shift so that we can implement Key bindings in the future
When the user is already in any input field

Although currently it ignores any modifier including Alt and stuff which im not sure is what you want?

@fluxxcode
Copy link
Owner

This is working well so far. But I think we should allow to automatically enter search while Shift is pressed.
Otherwise it doesn't work if the first letter is to be capitalized 🤔

@juliapaci
Copy link
Contributor Author

juliapaci commented Mar 2, 2024

Oops, i didn't realise that. Fixed in crumblingstatue@dffed3f.

@fluxxcode
Copy link
Owner

This works really great now! Will merge the changes once @crumblingstatue creates a PR :)

crumblingstatue added a commit to crumblingstatue/egui-file-dialog that referenced this issue Mar 5, 2024
fluxxcode fluxxcode#89 "Automatically search upon typing"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants