Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to get node version unless node is installed #91

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

luizkowalski
Copy link
Collaborator

I currently have Bun installed and just this morning, uninstalled Node. After that, I noticed that my Dockerfile keeps re-adding nodejs and npm. Debugging a little bit, the node_version method has a rescue that defaults to "lts" in case there's an error, and that's what happens when node command is not found. I figure that it should be safe to just not try to find a version if we are not using node anyways

@luizkowalski luizkowalski marked this pull request as ready for review April 6, 2024 22:25
@luizkowalski
Copy link
Collaborator Author

hmm, trying to run the failed test locally, but not only it fail with a different error, it also tries to add execjs to the Gemfile itself

image

gonna debug it tomorrow

@rubys
Copy link
Collaborator

rubys commented Apr 7, 2024

execjs will need a runtime.... it now supports bun and the dockerfile generator could be enhanced to try to match the runtime you are otherwise using; but for now I presume that could be a separate pull request.

@rubys rubys self-requested a review April 7, 2024 00:08
@luizkowalski luizkowalski merged commit 16dfb4c into main Apr 7, 2024
8 checks passed
@luizkowalski luizkowalski deleted the fix-node-missing-problem branch April 7, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants