Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not try to get node version unless node is installed #91

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Do not try to get node version unless node is installed #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83c63d5
Do not try to get node version unless node is installed
luizkowalski Apr 6, 2024
b2c02e4
install node if using execjs
rubys Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/generators/dockerfile_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,6 +1034,8 @@ def deploy_database
end

def node_version
return unless using_node? || using_execjs?

version = nil

if File.exist? ".node-version"
Expand Down
Loading