-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(afs): Add FMGC and FCU computer implementation #7587
Open
lukecologne
wants to merge
81
commits into
flybywiresim:master
Choose a base branch
from
lukecologne:fmgc-computer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28,638
−20,222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukecologne
force-pushed
the
fmgc-computer
branch
5 times, most recently
from
November 11, 2022 23:39
eaabc7a
to
fe3b057
Compare
lukecologne
force-pushed
the
fmgc-computer
branch
2 times, most recently
from
November 20, 2022 22:26
c1206d3
to
b6c320a
Compare
lukecologne
force-pushed
the
fmgc-computer
branch
2 times, most recently
from
December 21, 2022 18:53
4c01703
to
2c17a2f
Compare
lukecologne
force-pushed
the
fmgc-computer
branch
4 times, most recently
from
February 12, 2023 17:01
73f3b0b
to
4ec9f6f
Compare
lukecologne
force-pushed
the
fmgc-computer
branch
6 times, most recently
from
March 30, 2023 19:17
b922929
to
824dffc
Compare
lukecologne
force-pushed
the
fmgc-computer
branch
3 times, most recently
from
April 8, 2023 03:00
fd6e084
to
34a4e6b
Compare
lukecologne
force-pushed
the
fmgc-computer
branch
2 times, most recently
from
April 14, 2023 14:12
0fd8b4e
to
5f3e4d9
Compare
lukecologne
force-pushed
the
fmgc-computer
branch
from
April 28, 2023 17:07
f833205
to
8637144
Compare
lukecologne
force-pushed
the
fmgc-computer
branch
3 times, most recently
from
May 18, 2023 20:35
6ed6829
to
49f3cf8
Compare
lukecologne
force-pushed
the
fmgc-computer
branch
from
May 20, 2023 14:50
49f3cf8
to
bde03fc
Compare
…r ALT CRZ condition
lukecologne
force-pushed
the
fmgc-computer
branch
from
September 19, 2024 11:26
dce1ab1
to
921a836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4242, Fixes #6717, Fixes #6089, Fixes #2606, Fixes #8319, Fixes #8000, Fixes #8294, Fixes #8397
Supersedes #7301
Summary of Changes
This PR aims to add:
including the correct communication of these two computers with the peripheral devices and the rest of the systems and displays.
To Do until feature parity:
Bonus ToDos:
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
As this PR completely reimplements the FG and FCU logic, extensive testing is needed. The laws are unchanged, but still could be affected by the integration in the FMGC.
Possible tests (non-exhaustive, you can be creative here :) ):
Also, tests with various setups (such as hardware FCUs) would be nice to have
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.