refactor: remove simplane calls from pfd #7301
Open
+169
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracernz
reviewed
Jun 20, 2022
| @@ -115,6 +115,14 @@ export interface PFDSimvars { | |||
| xtk: number; | |||
| ldevRequestLeft: boolean; | |||
| ldevRequestRight: boolean; | |||
| baroMode: number; | |||
| baroUnit: number; | |||
| baroPressure: number; | |||
There was a problem hiding this comment.
Maybe a good idea to split these into left/right but reading the same A vars so we don't need to edit the PFD code later (just switch the A vars for L vars).
Saschl
force-pushed
the
refactor/remove-simplane
branch
from
aab0cb2
to
a9b3abf
Compare
2hwk
approved these changes
Feb 13, 2024
|
May want to look at the merge conflicts? |
|
Will be impacted by the potential future merge freeze. #8466 will be required to be merged into this PR at some point. |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.