Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: lint and styling overhaul #8466

Merged
merged 40 commits into from
Apr 27, 2024
Merged

style: lint and styling overhaul #8466

merged 40 commits into from
Apr 27, 2024

Conversation

Benjozork
Copy link
Member

@Benjozork Benjozork commented Feb 5, 2024 •
edited by 2hwk
Loading

Summary of Changes

  • Bump eslint-related package versions
  • Consolidate eslint configs for modern TS code under one config
  • Introduce Prettier as main formatting style, integrated with ESLint
  • Fix linting of package base JS
  • Fix lint issues now coming up after cleanup of configs/upgrade of packages

Testing instructions

  • Should not affect code, but make sure nothing is obviously broken
  • Focus on that the guidance (LNAV/VNAV) does not have any new bugs
    • Routes (or similar):
      • EDDM-LOWI LOC26R (circle to land)
      • KCRQ24 PADRZ2 CHKNN AVE ROBIE5 BORED KSJC30L (ILS)
      • EDDF/25L F250 SULUS1F SULUS Z12 LASGA T202 ATGUP ATG25L EDDB/25L
        EBBR-EGKK26L
  • EFB does not have incorrect/broken formatting

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@Benjozork
Merge branch 'master' into refactor/prepare-for-lint-overhaul
2ce0423 
# Conflicts:
#	fbw-a380x/src/systems/instruments/src/SD/Mailbox.tsx
#	fbw-a380x/src/systems/instruments/src/SD/StatusArea.tsx
@Benjozork Benjozork marked this pull request as draft February 24, 2024 17:48
@Benjozork
Merge branch 'master' into refactor/prepare-for-lint-overhaul
ff38cf4 
# Conflicts:
#	.eslintignore
#	fbw-a32nx/src/systems/fmgc/src/guidance/GuidanceController.ts
#	fbw-a32nx/src/systems/instruments/src/EFB/Dispatch/Pages/OverviewPage.tsx
#	fbw-a32nx/src/systems/instruments/src/EFB/UtilComponents/Form/Toggle.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/AltitudeIndicator.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/AttitudeIndicatorHorizon.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/LowerArea.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/PFD.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/SpeedIndicator.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/VerticalSpeedIndicator.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/shared/PFDSimvarPublisher.tsx
#	fbw-common/src/systems/instruments/src/EFB/ATC/ATC.tsx
#	fbw-common/src/systems/instruments/src/EFB/Apis/Navigraph/Components/Authentication.tsx
#	fbw-common/src/systems/instruments/src/EFB/Checklists/Checklists.tsx
#	fbw-common/src/systems/instruments/src/EFB/Checklists/ChecklistsPage.tsx
#	fbw-common/src/systems/instruments/src/EFB/Dashboard/Dashboard.tsx
#	fbw-common/src/systems/instruments/src/EFB/Dashboard/Widgets/Reminders/ChecklistsReminder.tsx
#	fbw-common/src/systems/instruments/src/EFB/Dashboard/Widgets/Reminders/MaintenanceReminder.tsx
#	fbw-common/src/systems/instruments/src/EFB/Dashboard/Widgets/Reminders/PinnedChartsReminder.tsx
#	fbw-common/src/systems/instruments/src/EFB/Dashboard/Widgets/Reminders/RemindersSection.tsx
#	fbw-common/src/systems/instruments/src/EFB/Dashboard/Widgets/Reminders/WeatherReminder.tsx
#	fbw-common/src/systems/instruments/src/EFB/Dashboard/Widgets/RemindersWidget.tsx
#	fbw-common/src/systems/instruments/src/EFB/Dispatch/Dispatch.tsx
#	fbw-common/src/systems/instruments/src/EFB/Dispatch/Pages/LoadsheetPage.tsx
#	fbw-common/src/systems/instruments/src/EFB/Failures/FailureButton.tsx
#	fbw-common/src/systems/instruments/src/EFB/Failures/Failures.tsx
#	fbw-common/src/systems/instruments/src/EFB/Failures/Pages/Comfort/AtaChapterPage.tsx
#	fbw-common/src/systems/instruments/src/EFB/Failures/Pages/Comfort/index.tsx
#	fbw-common/src/systems/instruments/src/EFB/Failures/Pages/Compact.tsx
#	fbw-common/src/systems/instruments/src/EFB/Ground/Ground.tsx
#	fbw-common/src/systems/instruments/src/EFB/Ground/Pages/Payload/A320_251N/A320Payload.tsx
#	fbw-common/src/systems/instruments/src/EFB/Ground/Pages/Payload/A320_251N/CargoWidget.tsx
#	fbw-common/src/systems/instruments/src/EFB/Ground/Pages/Payload/A380_842/A380Payload.tsx
#	fbw-common/src/systems/instruments/src/EFB/Ground/Pages/Payload/A380_842/CargoWidget.tsx
#	fbw-common/src/systems/instruments/src/EFB/Ground/Pages/Payload/Chart/ChartWidget.tsx
#	fbw-common/src/systems/instruments/src/EFB/Ground/Pages/Payload/PayloadElements.tsx
#	fbw-common/src/systems/instruments/src/EFB/Ground/Pages/Pushback/PushbackMap.tsx
#	fbw-common/src/systems/instruments/src/EFB/Ground/Pages/Pushback/PushbackPage.tsx
#	fbw-common/src/systems/instruments/src/EFB/Ground/Pages/Services/A320_251N/A320Services.tsx
#	fbw-common/src/systems/instruments/src/EFB/Ground/Pages/Services/A380_842/A380Services.tsx
#	fbw-common/src/systems/instruments/src/EFB/Navigation/Navigation.tsx
#	fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/LocalFilesPage/LocalFileChartSelector.tsx
#	fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/LocalFilesPage/LocalFileChartUI.tsx
#	fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/LocalFilesPage/LocalFilesPage.tsx
#	fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/NavigraphPage/NavigraphChartSelector.tsx
#	fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/NavigraphPage/NavigraphChartUI.tsx
#	fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/PinnedChartsPage.tsx
#	fbw-common/src/systems/instruments/src/EFB/Performance/Performance.tsx
#	fbw-common/src/systems/instruments/src/EFB/Presets/Presets.tsx
#	fbw-common/src/systems/instruments/src/EFB/Presets/Widgets/AircraftPresets.tsx
#	fbw-common/src/systems/instruments/src/EFB/Presets/Widgets/LightPresets.tsx
#	fbw-common/src/systems/instruments/src/EFB/Presets/Widgets/PresetsHelp.tsx
#	fbw-common/src/systems/instruments/src/EFB/Settings/Pages/AircraftOptionsPinProgramsPage.tsx
#	fbw-common/src/systems/instruments/src/EFB/Settings/Pages/AutomaticCallOutsPage.tsx
#	fbw-common/src/systems/instruments/src/EFB/Settings/Settings.tsx
#	fbw-common/src/systems/instruments/src/EFB/StatusBar/QuickControls.tsx
#	fbw-common/src/systems/instruments/src/EFB/StatusBar/StatusBar.tsx
#	fbw-common/src/systems/instruments/src/EFB/TODCalculator/Data/Data.tsx
#	fbw-common/src/systems/instruments/src/EFB/TODCalculator/GroundSpeed/GroundSpeedAuto/GroundSpeedAuto.tsx
#	fbw-common/src/systems/instruments/src/EFB/TODCalculator/GroundSpeed/GroundSpeedManual/GroundSpeedManual.tsx
#	fbw-common/src/systems/instruments/src/EFB/TODCalculator/Result/Result.tsx
#	fbw-common/src/systems/instruments/src/EFB/TODCalculator/TODCalculator.tsx
#	fbw-common/src/systems/instruments/src/EFB/ToolBar/ToolBar.tsx
#	fbw-common/src/systems/instruments/src/EFB/UtilComponents/Form/Select.tsx
#	fbw-common/src/systems/instruments/src/EFB/UtilComponents/Form/SelectInput/SelectInput.tsx
#	fbw-common/src/systems/instruments/src/EFB/UtilComponents/Modals/Modals.tsx
#	fbw-common/src/systems/instruments/src/EFB/UtilComponents/Navbar.tsx
#	fbw-common/src/systems/instruments/src/EFB/UtilComponents/ScrollableContainer.tsx
#	fbw-common/src/systems/instruments/src/EFB/UtilComponents/TooltipWrapper.tsx
#	fbw-common/src/systems/instruments/src/EFB/webpack.development.config.js
#	fbw-common/src/systems/instruments/src/EFB/webpack.msfs.config.js
#	fbw-common/src/systems/instruments/src/ND/ND.tsx
@Benjozork
run lint
3ea437d
@Benjozork Benjozork changed the title refactor(lint): prepare for lint overhaul refactor(lint): lint overhaul Feb 24, 2024
@Benjozork Benjozork force-pushed the refactor/prepare-for-lint-overhaul branch from d228600 to e33d78e Compare February 24, 2024 20:30
@Benjozork Benjozork marked this pull request as ready for review February 24, 2024 20:30
@Benjozork
Merge branch 'refs/heads/master' into refactor/prepare-for-lint-overhaul
2c50330 
# Conflicts:
#	fbw-a32nx/src/systems/failures/src/a320.ts
#	fbw-a32nx/src/systems/instruments/src/Common/EWDMessages.tsx
#	fbw-a32nx/src/systems/instruments/src/EWD/PseudoFWC.ts
#	fbw-a32nx/src/systems/instruments/src/SD/Pages/Crz/Crz.tsx
#	fbw-a32nx/src/systems/instruments/src/SD/Pages/Press/Press.tsx
#	fbw-common/src/systems/instruments/src/EFB/Apis/Simbrief/simbriefInterface.ts
#	fbw-common/src/systems/instruments/src/EFB/Apis/Simbrief/simbriefParser.ts
#	fbw-common/src/systems/instruments/src/EFB/Dashboard/Widgets/FlightWidget.tsx
#	fbw-common/src/systems/instruments/src/EFB/Ground/Pages/Fuel/A380_842/A380Fuel.tsx
#	fbw-common/src/systems/instruments/src/EFB/Store/features/simBrief.ts
@Benjozork
style: run lint after merge
990f0ff
@Benjozork
fix: cast
925ddff
@2hwk 2hwk changed the title chore: styling and lint overhaul style: lint and styling overhaul Apr 24, 2024
@2hwk
Copy link
Member

2hwk commented Apr 25, 2024

This will enforce a merge freeze on ts/js/tsx when we are prepared on our side. At this moment, the status of this is pending.

This was referenced Apr 25, 2024
Merged
Merged
Merged
Merged
Open
@noonebling
Copy link

Quality Assurance Trainee Report

Discord : noonebling
Object of testing: #8466
Tier of Testing : 2
Date : 25/04/2024

Testing Process:

  1. Setup flight with route EDDF/25L F250 SULUS1F SULUS Z12 LASGA T202 ATGUP ATG25L EDDB/25L
  2. Checked for any bugs with LNAV/VNAV

Negatives:
N/A

Testing Results:
Passed

Conclusions:
Works as expected

@2hwk
Copy link
Member

2hwk commented Apr 27, 2024

Quality Assurance Report

Tier of Testing : 2
Date : 27/04/2024

Testing Process:

  • Route YPPH/24 N0429F370 AVNEX3 AVNEX Y15 ESDEG/N0433F390 Y15 VETEL Z55 KA DCT YPKA/08
  • Checked for bugs with LNAV/VNAV - Found but consistent with master
  • EFB check not passed

Negatives:

  • EFB regression - Pushback page indicator no longer works reliably.

Testing Results:
Failed

Conclusions:
Not Passed.

@2hwk 2hwk added QA Failed and removed QA Passed labels Apr 27, 2024
@2hwk
Copy link
Member

2hwk commented Apr 27, 2024

Quality Assurance Report

Tier of Testing : 2
Date : 27/04/2024

Testing Process:

  • Route KCRQ24 PADRZ2 CHKNN AVE ROBIE5 BORED KSJC30L (ILS)
  • LNAV/VNAV - Bug found with SID entry removing runway but consistent with master

Negatives:

  • N/A

Testing Results:
Passed

Conclusions:
Passed

@Benjozork Benjozork merged commit 7518ab0 into flybywiresim:master Apr 27, 2024
7 checks passed
@2hwk 2hwk mentioned this pull request May 6, 2024
Open
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alepouna alepouna alepouna left review comments

@tracernz tracernz tracernz approved these changes

@2hwk 2hwk 2hwk approved these changes

Assignees
No one assigned
Labels
QA Passed QA Tier 2
Projects
Quality Assurance
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Benjozork @tracernz @marvin-wtt @2hwk @noonebling @alepouna