Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pfd): Add vertical deviation indicator, ROW/ROP/OANS warnings #8605

Merged
merged 30 commits into from
Jun 15, 2024
Merged

feat(pfd): Add vertical deviation indicator, ROW/ROP/OANS warnings #8605

merged 30 commits into from
Jun 15, 2024

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Apr 1, 2024 •
edited
Loading

Summary of Changes

Relevant for both A380X and A32NX.

  • Adds OANS, ROP and ROW warnings to the PFD and aural alerts
  • Transmits new EGPWS discrete words from the GPWS module
  • Implements stall warning (aural alert and PFD warning)

A380X only:

  • Adds GPWS alerts to PFD
  • Ports the VDEV indicator, as well as the upper and lower speed limits from the a32nx to the a380x
  • Adds LS reminder for ILS, subsequently move marker (OM/MM/IM) information
  • ILS information: Frequency now has the same font size before and after decimal point, see references

Screenshots (if necessary)

image
image
image
image
image
image
image
image
image
image

A380X only:
image
image
image
image
image
image
image
image

References

https://www.youtube.com/watch?v=EorNGwNTzwQ
https://www.navblue.aero/product/rops-plus/
https://safetyfirst.airbus.com/app/themes/mh_newsdesk/documents/archives/the-runway-overrun-prevention-system.pdf
https://www.youtube.com/watch?v=FbCIjWaMqTI
https://www.youtube.com/watch?v=hDh_9MEz-hg
image

Additional context

Discord username (if different from GitHub): floridude

Testing instructions

Testing of ROW/ROP on A32NX not yet possible.

For A32NX:
Test 1: Stall warning
Bring aircraft into alternate law (e.g. by turning both SECs to OFF), throttle to idle and maximum pitch up, until the aircraft enters a stall.
An aural warning "STALL, STALL", shall be heard.

Test 2: GPWS warnings
Please perform a flight triggering the following GPWS warnings, and confirm that there has been no regression, i.e. they still trigger:

  • Sinkrate
  • Pull Up
  • Terrain
  • Don't Sink
  • Too Low Gear
  • Too Low Flaps
  • Too Low Terrain
  • Glideslope

Test 3: ROP/ROW Warnings in A32NX
To trigger these manually, set the local variable A32NX_ROW_ROP_WORD_1 to the following value:
MAX BRAKING: 14046724096.000
MAX REVERSE: 14053015552.000
IF WET: RWY TOO SHORT: 14060355584.000
RWY TOO SHORT: 14068219904.000

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@flogross89 flogross89 added Not Ready For Review Still draft but needs a GitHub build and removed Not Ready For Review Still draft but needs a GitHub build labels Apr 1, 2024
@Popespice
Copy link

Popespice commented Apr 3, 2024 •
edited
Loading

Quality Assurance Trainee Report

Discord : Popepsice
Object of testing: #8605
Tier of Testing : 2
Date : 02042024

Testing Process: A32NX (Note, aircraft was on the ground during testing as feature is not ready for in-flight testing yet, all simvars had to be activated manually)

  1. Log into sim
  2. Load into aircraft
  3. Power on through expedited power-on through flypad
  4. Open Settings
  5. Turn on developer mode
  6. Navigate to top toolbar and follow this path: Tools --> Behaviors --> LocalVariables
  7. Manually change the following from 0.0 to 1.0
    "MAX REVERSE": A32NX_AUTOBRAKE_ROP_ACTIVE
    "MAX BRAKING + MAX REVERSE": A32NX_MANUAL_BRAKING_ROP_ACTIVE
    "IF WET:RWY TOO SHORT": A32NX_ROW_IF_WET_RWY_TOO_SHORT
    "RWY TOO SHORT": A32NX_ROW_RWY_TOO_SHORT
    "RWY AHEAD": A32NX_OANS_RWY_AHEAD
  8. After each message displays on screen, change variable back from 1.0 to 0.0
  9. Observe each message displays correctly

Negatives:
N/A

Testing Results:
Passed

Conclusions:
Works as expected. Actions do not trigger in flight, all testing was performed on the ground.

Media:
N/A

tracernz
tracernz previously requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@tracernz tracernz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See dev channel.

@flogross89 flogross89 added Not Ready For Testing Not ready for testing as still being discussed or developed. and removed QA Tier 2 QA Passed QA Ready to Test labels Apr 4, 2024
@tracernz
Copy link
Member

tracernz commented Apr 5, 2024

STALL STALL is a bit too high
image

@flogross89 flogross89 requested a review from tracernz April 6, 2024 13:17
@flogross89 flogross89 removed the Not Ready For Testing Not ready for testing as still being discussed or developed. label Apr 8, 2024
@2hwk 2hwk added Do Not Merge Not Ready For Testing Not ready for testing as still being discussed or developed. QA Ready to Test QA Tier 1 and removed Not Ready For Testing Not ready for testing as still being discussed or developed. labels Apr 23, 2024
@2hwk
Copy link
Member

2hwk commented Apr 25, 2024 •
edited
Loading

Could be impacted by the potential future merge freeze. #8466 may be required to be merged into this PR at some point. We're not final on this.

@2hwk
Copy link
Member

2hwk commented May 4, 2024

Noticing some weirdness with this branch when powering on the A/C, i.e. master caution/warning sounds which should not happen.

Maybe related to pseudoFWC changes?

@2hwk 2hwk added QA Tier 2 and removed QA Tier 1 labels May 4, 2024
@2hwk 2hwk added this to the v0.12.0 milestone May 4, 2024
@2hwk 2hwk added the QA Failed label May 4, 2024
@flogross89
Copy link
Contributor Author

Noticing some weirdness with this branch when powering on the A/C, i.e. master caution/warning sounds which should not happen.

Maybe related to pseudoFWC changes?

Is the behavior correct on master, i.e. are we sure that this behavior is introduced with this PR? There's no change where I could explain this behavior from :/

@2hwk
Copy link
Member

2hwk commented May 10, 2024

Noticing some weirdness with this branch when powering on the A/C, i.e. master caution/warning sounds which should not happen.
Maybe related to pseudoFWC changes?

Is the behavior correct on master, i.e. are we sure that this behavior is introduced with this PR? There's no change where I could explain this behavior from :/

Definitely not the case in the current master branch, I will check again this weekend.

@flogross89
Copy link
Contributor Author

Noticing some weirdness with this branch when powering on the A/C, i.e. master caution/warning sounds which should not happen.
Maybe related to pseudoFWC changes?

Is the behavior correct on master, i.e. are we sure that this behavior is introduced with this PR? There's no change where I could explain this behavior from :/

Definitely not the case in the current master branch, I will check again this weekend.

See ping in Discord, I'd be happy if you could somehow help me reproduce this :) If it's occuring in the A32NX, I don't know which sounds to expect at startup

@flogross89 flogross89 requested a review from tracernz May 14, 2024 18:49
@flogross89
inhibit single chimes for the first two seconds after power-on
3fd5fab
@flogross89
Merge branch 'master' into fix-a380x-pfd-vdev
3922152 
# Conflicts:
#	fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/LandingSystemIndicator.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/PFD.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/SpeedIndicator.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/instrument.tsx
@flogross89
Copy link
Contributor Author

Noticing some weirdness with this branch when powering on the A/C, i.e. master caution/warning sounds which should not happen.
Maybe related to pseudoFWC changes?

Is the behavior correct on master, i.e. are we sure that this behavior is introduced with this PR? There's no change where I could explain this behavior from :/

Definitely not the case in the current master branch, I will check again this weekend.

This should be addressed now with the FWC timeout after startup

@noonebling
Copy link

Quality Assurance Trainee Report

Discord : noonebling
Object of testing: 8605
Tier of Testing : 2
Date : 15/06/2024

Testing Process:

Only for A32NX:
TEST 1:
Brought aircraft into alternate law, throttle idle and maximum pitch up, until the aircraft enters a stall
Aural warning "STALL, STALL" heard

TEST 2:
Performed flight triggering GPWS warnings for Sinkrate, Pull Up, Terrain, Don't Sink, Too Low Gear, Too Low Flaps, Too Low Terrain and Glideslope with no regression

TEST 3:
Set the local variable A32NX_ROW_ROP_WORD_1 to the following value:
MAX BRAKING: 14046724096.000
MAX REVERSE: 14053015552.000
IF WET: RWY TOO SHORT: 14060355584.000
RWY TOO SHORT: 14068219904.000
Checked for ROP warnings

Negatives:
N/A

Testing Results:
Passed

Conclusions:
Works as expected

@flogross89 flogross89 merged commit 4bedac5 into flybywiresim:master Jun 15, 2024
7 checks passed
@flogross89 flogross89 deleted the fix-a380x-pfd-vdev branch June 15, 2024 19:26
BlueberryKing added a commit to BlueberryKing/a32nx that referenced this pull request Jun 16, 2024
@BlueberryKing
Revert "feat(pfd): Add vertical deviation indicator, ROW/ROP/OANS war…
e4a5250 
…nings (flybywiresim#8605)"

This reverts commit 4bedac5.
BlueberryKing added a commit that referenced this pull request Jun 16, 2024
@BlueberryKing
fix: Revert "feat(pfd): Add vertical deviation indicator, ROW/ROP/OAN…
99b7564 
…S warnings (#8605)" (#8680)

Revert "feat(pfd): Add vertical deviation indicator, ROW/ROP/OANS warnings (#8605)"

This reverts commit 4bedac5.
@flogross89 flogross89 restored the fix-a380x-pfd-vdev branch June 16, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2hwk 2hwk 2hwk approved these changes

@tracernz tracernz Awaiting requested review from tracernz

Assignees
No one assigned
Labels
QA Passed QA Ready to Test QA Tier 2
Projects
Quality Assurance
Status: ✔️ Done
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@flogross89 @Popespice @tracernz @2hwk @noonebling