Unpin pandas #1889
Closed
Unpin pandas #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringohoffman
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Fixes #3680; this pin was added in flyteorg#136: https://github.com/flyteorg/flytekit/pull/136/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R18 ~3 years ago when the latest pandas version was 1.2.1; flytekit is not using any features that have broken any of its tests in upgrading to use pandas >=2.0.0 Signed-off-by: Matthew Hoffman <matthew@protopia.ai>
ringohoffman
force-pushed
the
unpin-pandas
branch
from
e97b8f6
to
713f0cd
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1889 +/- ##
===========================================
- Coverage 55.23% 40.30% -14.94%
===========================================
Files 300 165 -135
Lines 22381 16266 -6115
Branches 3359 3359
===========================================
- Hits 12363 6556 -5807
+ Misses 9856 9548 -308
Partials 162 162 ☔ View full report in Codecov by Sentry. |
pingsutw
reviewed
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixes flyteorg/flyte#3680: unpin pandas
Type
Are all requirements met?
Complete description
this pin was added in #136: https://github.com/flyteorg/flytekit/pull/136/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R18 ~3 years ago when the latest pandas version was 1.2.1; flytekit is not using any features that have broken any of its tests in upgrading to use pandas >=2.0.0
Tracking Issue
flyteorg/flyte#3680