Python-native typing support #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumare3
reviewed
Jul 23, 2020
flytekit/annotated/stuff.py
Outdated
| retries=0, | ||
| interruptible=None, | ||
| deprecated='', | ||
| storage_request=None, |
There was a problem hiding this comment.
i want to club the requests and limits as structs. This simplifies adding new ones
kumare3
reviewed
Jul 23, 2020
flytekit/annotated/stuff.py
Outdated
| cpu_limit=None, | ||
| gpu_limit=None, | ||
| memory_limit=None, | ||
| cache=False, |
kumare3
reviewed
Jul 23, 2020
flytekit/annotated/sample.py
Outdated
| @workflow(outputs=["real_b"]) | ||
| def my_workflow() -> WorkflowOutputs: | ||
| # a = x(s=3) | ||
| b = x(s=x(s=3)) |
There was a problem hiding this comment.
can we get a little more complex example, where we have 3 nodes, multiple outputs and inputs?
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 80.88% 80.41% -0.47%
==========================================
Files 225 235 +10
Lines 14669 15441 +772
Branches 1204 1323 +119
==========================================
+ Hits 11865 12417 +552
- Misses 2521 2706 +185
- Partials 283 318 +35
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 96.00% 96.00%
=======================================
Files 2 2
Lines 75 75
Branches 8 8
=======================================
Hits 72 72
Misses 1 1
Partials 2 2 Continue to review full report at Codecov.
|
* comparison working with operator overloading * Branching work in progress * Complete evaluation * Branches working * All conditional cases * Update flytekit/common/workflow.py Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * fixed one comment * Fixes to execution state Co-authored-by: Ketan Umare <kumare@lyft.com> Co-authored-by: Ketan Umare <16888709+kumare3@users.noreply.github.com>
wild-endeavor
changed the title
wild-endeavor
changed the title
katrogan
approved these changes
Jan 26, 2021
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
ringohoffman
added a commit
to ringohoffman/flytekit
that referenced
this pull request
Oct 12, 2023
Fixes #3680; this pin was added in flyteorg#136: https://github.com/flyteorg/flytekit/pull/136/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R18 ~3 years ago when the latest pandas version was 1.2.1; flytekit is not using any features that have broken any of its tests in upgrading to use pandas >=2.0.0
ringohoffman
added a commit
to ringohoffman/flytekit
that referenced
this pull request
Oct 12, 2023
Fixes #3680; this pin was added in flyteorg#136: https://github.com/flyteorg/flytekit/pull/136/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R18 ~3 years ago when the latest pandas version was 1.2.1; flytekit is not using any features that have broken any of its tests in upgrading to use pandas >=2.0.0 Signed-off-by: Matthew Hoffman <matthew@protopia.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Please see the proposal doc at https://docs.google.com/document/d/17rNKg6Uvow8CrECaPff96Tarr87P2fn4ilf_Tv2lYd4
https://flytecookbook.readthedocs.io/en/latest/
Type
Are all requirements met?