forked from line/armeria
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make Dropwizard Metrics and Prometheus optional for Spring Boot integ…
…ration (line#2107) Motivation: A user may not want to pull in Dropwizard Metrics at all. Modifications: - Access anything related with Dropwizard using the reflection API. - Make `io.dropwizard.metrics:metrics-json` optional. Result: - Fixes line#2106 - A user can exclude `io.dropwizard.metrics:metrics-core` as well as `metrics-json`.
- Loading branch information
Showing
7 changed files
with
179 additions
and
66 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
...t-autoconfigure/src/main/java/com/linecorp/armeria/internal/spring/DropwizardSupport.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /* | ||
| * Copyright 2019 LINE Corporation | ||
| * | ||
| * LINE Corporation licenses this file to you under the Apache License, | ||
| * version 2.0 (the "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at: | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package com.linecorp.armeria.internal.spring; | ||
|
|
||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| import com.codahale.metrics.MetricRegistry; | ||
| import com.codahale.metrics.json.MetricsModule; | ||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import com.fasterxml.jackson.databind.SerializationFeature; | ||
|
|
||
| import com.linecorp.armeria.common.HttpResponse; | ||
| import com.linecorp.armeria.common.HttpStatus; | ||
| import com.linecorp.armeria.common.MediaType; | ||
| import com.linecorp.armeria.server.ServerBuilder; | ||
| import com.linecorp.armeria.spring.ArmeriaSettings; | ||
|
|
||
| import io.micrometer.core.instrument.MeterRegistry; | ||
| import io.micrometer.core.instrument.dropwizard.DropwizardMeterRegistry; | ||
|
|
||
| final class DropwizardSupport { | ||
|
|
||
| static boolean addExposition(ArmeriaSettings settings, ServerBuilder server, | ||
| MeterRegistry meterRegistry) { | ||
| final String metricsPath = settings.getMetricsPath(); | ||
| assert metricsPath != null; | ||
|
|
||
| if (!(meterRegistry instanceof DropwizardMeterRegistry)) { | ||
| return false; | ||
| } | ||
| final MetricRegistry dropwizardRegistry = | ||
| ((DropwizardMeterRegistry) meterRegistry).getDropwizardRegistry(); | ||
| final ObjectMapper objectMapper = new ObjectMapper() | ||
| .enable(SerializationFeature.INDENT_OUTPUT) | ||
| .registerModule(new MetricsModule(TimeUnit.SECONDS, TimeUnit.MILLISECONDS, true)); | ||
|
|
||
| server.route() | ||
| .get(settings.getMetricsPath()) | ||
| .build((ctx, req) -> HttpResponse.of(HttpStatus.OK, MediaType.JSON_UTF_8, | ||
| objectMapper.writeValueAsBytes(dropwizardRegistry))); | ||
| return true; | ||
| } | ||
|
|
||
| private DropwizardSupport() {} | ||
| } |
68 changes: 68 additions & 0 deletions
68
...t-autoconfigure/src/main/java/com/linecorp/armeria/internal/spring/PrometheusSupport.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| /* | ||
| * Copyright 2019 LINE Corporation | ||
| * | ||
| * LINE Corporation licenses this file to you under the Apache License, | ||
| * version 2.0 (the "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at: | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package com.linecorp.armeria.internal.spring; | ||
|
|
||
| import java.util.Optional; | ||
| import java.util.Set; | ||
|
|
||
| import com.linecorp.armeria.server.ServerBuilder; | ||
| import com.linecorp.armeria.server.metric.PrometheusExpositionService; | ||
| import com.linecorp.armeria.spring.ArmeriaSettings; | ||
|
|
||
| import io.micrometer.core.instrument.MeterRegistry; | ||
| import io.micrometer.core.instrument.composite.CompositeMeterRegistry; | ||
| import io.micrometer.prometheus.PrometheusMeterRegistry; | ||
| import io.prometheus.client.CollectorRegistry; | ||
|
|
||
| final class PrometheusSupport { | ||
|
|
||
| static boolean addExposition(ArmeriaSettings settings, ServerBuilder server, | ||
| MeterRegistry meterRegistry) { | ||
|
|
||
| final String metricsPath = settings.getMetricsPath(); | ||
| assert metricsPath != null; | ||
|
|
||
| for (;;) { | ||
| if (meterRegistry instanceof PrometheusMeterRegistry) { | ||
| final CollectorRegistry prometheusRegistry = | ||
| ((PrometheusMeterRegistry) meterRegistry).getPrometheusRegistry(); | ||
| server.service(metricsPath, new PrometheusExpositionService(prometheusRegistry)); | ||
| return true; | ||
| } | ||
|
|
||
| if (meterRegistry instanceof CompositeMeterRegistry) { | ||
| final Set<MeterRegistry> childRegistries = | ||
| ((CompositeMeterRegistry) meterRegistry).getRegistries(); | ||
| final Optional<PrometheusMeterRegistry> opt = | ||
| childRegistries.stream() | ||
| .filter(PrometheusMeterRegistry.class::isInstance) | ||
| .map(PrometheusMeterRegistry.class::cast) | ||
| .findAny(); | ||
|
|
||
| if (!opt.isPresent()) { | ||
| return false; | ||
| } | ||
|
|
||
| meterRegistry = opt.get(); | ||
| continue; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
| } | ||
|
|
||
| private PrometheusSupport() {} | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters