-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Dropwizard Metrics and Prometheus optional for Spring Boot integration #2107
Conversation
Motivation: A user may not want to pull in Dropwizard Metrics at all. Modifications: - Access anything related with Dropwizard using the reflection API. - Make `io.dropwizard.metrics:metrics-json` optional. Result: - Fixes line#2106 - A user can exclude `io.dropwizard.metrics:metrics-core` as well as `metrics-json`.
@adriancole PTAL. I think now you can even exclude |
testing now.. the code looks correct |
...toconfigure/src/main/java/com/linecorp/armeria/internal/spring/ArmeriaConfigurationUtil.java
Outdated
Show resolved
Hide resolved
verified openzipkin/zipkin#2818 (comment) |
Codecov Report
@@ Coverage Diff @@
## master #2107 +/- ##
============================================
- Coverage 73.71% 73.66% -0.06%
- Complexity 9466 9471 +5
============================================
Files 831 833 +2
Lines 36495 36513 +18
Branches 4516 4521 +5
============================================
- Hits 26903 26898 -5
- Misses 7273 7293 +20
- Partials 2319 2322 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retested.. still works!
...boot-autoconfigure/src/main/java/com/linecorp/armeria/internal/spring/PrometheusSupport.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
...toconfigure/src/main/java/com/linecorp/armeria/internal/spring/ArmeriaConfigurationUtil.java
Outdated
Show resolved
Hide resolved
Thanks for revieweing! |
…ration (line#2107) Motivation: A user may not want to pull in Dropwizard Metrics at all. Modifications: - Access anything related with Dropwizard using the reflection API. - Make `io.dropwizard.metrics:metrics-json` optional. Result: - Fixes line#2106 - A user can exclude `io.dropwizard.metrics:metrics-core` as well as `metrics-json`.
…ration (line#2107) Motivation: A user may not want to pull in Dropwizard Metrics at all. Modifications: - Access anything related with Dropwizard using the reflection API. - Make `io.dropwizard.metrics:metrics-json` optional. Result: - Fixes line#2106 - A user can exclude `io.dropwizard.metrics:metrics-core` as well as `metrics-json`.
Motivation:
A user may not want to pull in Dropwizard Metrics or Prometheus at all.
Modifications:
io.dropwizard.metrics:metrics-json
andio.micrometer:micrometer-registry-prometheus
optional.Result:
io.dropwizard.metrics:metrics-core
as well asmetrics-json
.io.micrometer:micrometer-registry-prometheus