Throw an error when I18n.strftime() takes an invalid date #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -772,6 +772,10 @@ | |||
|
|
|||
| options = this.prepareOptions(options, DATE); | |||
|
|
|||
| if (isNaN(date.getTime())) { | |||
| throw new Error('I18n.strftime() requires a valid date object, but received an invalid date.'); | |||
There was a problem hiding this comment.
Does Error work in every JS environment?
There was a problem hiding this comment.
Yes, Error constructor is one of the global objects that all the JS environments (ancient browsers, Node.js, Electron etc.) have.
|
Can you add an entry to CHANGELOG? |
Currently, I18n.strftime produces a wrongly formatted string when it takes an invalid date object. For example,
```
I18n.strftime(new Date('foo'), '%Y%m%d');
//=> 'NaNaNaN'
```
|
|
Thanks! |
PikachuEXE
added a commit
that referenced
this pull request
Jan 6, 2016
Throw an error when I18n.strftime() takes an invalid date
|
No problem! Thanks for your speedy review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
JavaScript
Dateinstance can be aninvalid datein some cases. For example,Currently,
I18n.strftimeproduces a wrongly formatted string when it takes an invalid date object. For example,Solution
I updated
I18n.strftimeto immediately throw an error when it takes aninvalid dateobject. This change prevents it from producing broken strings likeNaNaN.