fixes to load properly VCF samples dict from _samples.avro #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves bigdatagenomics#909: * Refactors `org.bdgenomics.adam.rdd.variation` to add `GenomicRDD`s for `Genotype`, `Variant`, and `VariantContext`. These classes write sequence and sample metadata to disk. * Refactors `ADAMRDDFunctions` to an abstract class in preparation for further refactoring in bigdatagenomics#1011. * Added `AvroGenomicRDD` trait which consolidates Parquet + Avro metadata writing code across all Avro data models.
fnothaft
force-pushed
the
genotypes-rdd
branch
4 times, most recently
from
4c52f92
to
525fda8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem that in current code the sequence of actions:
ADAMContext.loadGenotypes()fails for two reasons:
_rgdict.avrowhen in fact the vcf derived sample metadata is named_samples.avroThis PR fixes these issues such that writing and loading genotype data works correctly.