-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seeking co-maintainers! #48
Comments
Hey, @davidtheclark here at galvanize would like to help you with the react repo if you want to, we are currently using it for the next version of our UI. For us would work better if we can fork this repo and created a new package from it. |
Sure, @nahumzs. Feel free to file a PR adding a link to this repo's README. |
Meanwhile, reactjs/rfcs#109 and react-events, as a focus managed bundled inside React, are going to make this package obsolete. |
🤚 @davidtheclark could I get collaborator here as well? Trying to do a synced update across the chain to |
Ditto to what @wldcordeiro said--I now have collaborator access to react-aria-modal but it'd be nice to be able to fix #24, which would also allow me to add tests to react-aria-modal. |
Is there still a call for maintainers? |
@davidtheclark This project, as well as focus-trap and tabbable, are really useful. I'd like to give a try to helping maintain this one. I'm |
@davidtheclark Thanks for upgrading me to contributor so I can merge PRs. Looking at the PRs, there are a number from Dependabot which I'd like to merge. There are also a few other PRs I'd merge right away also, related to dependencies and some bugs. So I would do this:
After all that, I would want to publish a new major. Too many changes to chance a minor. Should I just go ahead and start merging stuff at will? Do you have a set process to follow for publishing? I noticed a commit from you a long time ago where you had When you publish, do you publish manually from your system or some other way through CI somewhere? I see integration with TravisCI, but that looks like it's just for running tests. |
Yes, feel free to take the reins.
Yes, that's how I typically do it.
I've been publishing manually from my computer with |
@davidtheclark Perfect, thank you! 👍 |
@davidtheclark Hey, so I've made a bunch of updates and merged a few PRs per the plan I shared with you a couple of weeks ago. Did you ever give me permission to publish on NPM? We're ready for 7.0.0 (because of breaking changes). |
@stefcameron yes, you have access to publish on npm. |
@stefcameron what do you think about setting up https://github.com/atlassian/changesets? @davidtheclark has given me write access also; so was going to push up some sort of CI using GH Actions to handle these publishes. |
@maraisr Interesting you bring that up! I noticed this project a few weeks ago and took note of it. I've been curious about how it works in practice since it seems quite handy in theory. I'd like to publish 7.0.0 tomorrow so as not to delay any longer, but if you know how to set that all up, let's give it a try for future changes/releases! Sounds good? |
Fixes #48 now that we're 2 maintainers taking over. Based on the amount of activity and the stability of the code base, I think we should be good for a bit.
Fixes #48 now that we're 2 maintainers taking over. Based on the amount of activity and the stability of the code base, I think we should be good for a bit.
I've been shifting my focus away from UI development, so don't plan on addressing new issues myself. If you use this library and want to see development continue, you can make that happen by becoming a co-maintainer — with permissions to triage issues, merge PRs, cut releases, etc.
Please comment below if you're interested!
Another possibility is for a dedicated owner to fork this code and create a new package. I'd be happy to link to that library from the README of this one.
The text was updated successfully, but these errors were encountered: