Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking co-maintainers! #48

Closed
davidtheclark opened this issue Jun 8, 2019 · 14 comments · Fixed by #92
Closed

Seeking co-maintainers! #48

davidtheclark opened this issue Jun 8, 2019 · 14 comments · Fixed by #92

Comments

@davidtheclark
Copy link
Collaborator

I've been shifting my focus away from UI development, so don't plan on addressing new issues myself. If you use this library and want to see development continue, you can make that happen by becoming a co-maintainer — with permissions to triage issues, merge PRs, cut releases, etc.

Please comment below if you're interested!

Another possibility is for a dedicated owner to fork this code and create a new package. I'd be happy to link to that library from the README of this one.

@nahumzs
Copy link

nahumzs commented Jun 11, 2019

Hey, @davidtheclark here at galvanize would like to help you with the react repo if you want to, we are currently using it for the next version of our UI.

For us would work better if we can fork this repo and created a new package from it.

@davidtheclark
Copy link
Collaborator Author

For us would work better if we can fork this repo and created a new package from it.

Sure, @nahumzs. Feel free to file a PR adding a link to this repo's README.

@theKashey
Copy link

Meanwhile, reactjs/rfcs#109 and react-events, as a focus managed bundled inside React, are going to make this package obsolete.

@wldcordeiro
Copy link
Collaborator

🤚 @davidtheclark could I get collaborator here as well? Trying to do a synced update across the chain to react-aria-modal 😄

@toolness
Copy link

toolness commented Dec 2, 2019

Ditto to what @wldcordeiro said--I now have collaborator access to react-aria-modal but it'd be nice to be able to fix #24, which would also allow me to add tests to react-aria-modal.

@maraisr
Copy link
Contributor

maraisr commented Apr 30, 2020

Is there still a call for maintainers?

@stefcameron
Copy link
Member

@davidtheclark This project, as well as focus-trap and tabbable, are really useful. I'd like to give a try to helping maintain this one. I'm stefcameron over on NPM as well, for publishing purposes.

@stefcameron
Copy link
Member

@davidtheclark Thanks for upgrading me to contributor so I can merge PRs. Looking at the PRs, there are a number from Dependabot which I'd like to merge. There are also a few other PRs I'd merge right away also, related to dependencies and some bugs. So I would do this:

After all that, I would want to publish a new major. Too many changes to chance a minor.

Should I just go ahead and start merging stuff at will?

Do you have a set process to follow for publishing? I noticed a commit from you a long time ago where you had HEAD in the CHANGELOG and then you updated that to 6.0.0 manually. Is that just a pattern you follow, adding things to the CHANGELOG under HEAD until you're ready to publish a new version?

When you publish, do you publish manually from your system or some other way through CI somewhere? I see integration with TravisCI, but that looks like it's just for running tests.

@davidtheclark
Copy link
Collaborator Author

Should I just go ahead and start merging stuff at will?

Yes, feel free to take the reins.

I noticed a commit from you a long time ago where you had HEAD in the CHANGELOG and then you updated that to 6.0.0 manually. Is that just a pattern you follow, adding things to the CHANGELOG under HEAD until you're ready to publish a new version?

Yes, that's how I typically do it.

When you publish, do you publish manually from your system or some other way through CI somewhere?

I've been publishing manually from my computer with npm publish.

@stefcameron
Copy link
Member

@davidtheclark Perfect, thank you! 👍

@stefcameron
Copy link
Member

@davidtheclark Hey, so I've made a bunch of updates and merged a few PRs per the plan I shared with you a couple of weeks ago. Did you ever give me permission to publish on NPM? We're ready for 7.0.0 (because of breaking changes).

@davidtheclark
Copy link
Collaborator Author

@stefcameron yes, you have access to publish on npm.

@maraisr
Copy link
Contributor

maraisr commented Jun 30, 2020

@stefcameron what do you think about setting up https://github.com/atlassian/changesets? @davidtheclark has given me write access also; so was going to push up some sort of CI using GH Actions to handle these publishes.

@stefcameron
Copy link
Member

@maraisr Interesting you bring that up! I noticed this project a few weeks ago and took note of it. I've been curious about how it works in practice since it seems quite handy in theory. I'd like to publish 7.0.0 tomorrow so as not to delay any longer, but if you know how to set that all up, let's give it a try for future changes/releases! Sounds good?

stefcameron added a commit that referenced this issue Aug 8, 2020
Fixes #48 now that we're 2 maintainers taking over. Based on the
amount of activity and the stability of the code base, I think we
should be good for a bit.
stefcameron added a commit that referenced this issue Aug 15, 2020
Fixes #48 now that we're 2 maintainers taking over. Based on the
amount of activity and the stability of the code base, I think we
should be good for a bit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants