Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove call for maintainers #92

Merged
merged 2 commits into from
Aug 15, 2020
Merged

Remove call for maintainers #92

merged 2 commits into from
Aug 15, 2020

Conversation

stefcameron
Copy link
Member

Fixes #48 now that we're 2 maintainers taking over. Based on the
amount of activity and the stability of the code base, I think we
should be good for a bit.

Fixes #48 now that we're 2 maintainers taking over. Based on the
amount of activity and the stability of the code base, I think we
should be good for a bit.
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2020

🦋 Changeset is good to go

Latest commit: b0dd746

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stefcameron
Copy link
Member Author

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

I don't think this is something that warrants publishing. It'll eventually get published, but doesn't warrant a patch in and of itself.

@stefcameron
Copy link
Member Author

@maraisr OK with this?

I was also thinking it would make sense to bring tabbable and focus-trap into this org since they're "part of the family". We can keep their calls for maintainers open. But it would at least give us the ability to do things there as well, since I think #86 should really be fixed there instead of here.

@maraisr
Copy link
Contributor

maraisr commented Aug 9, 2020

Hi @stefcameron yeah man. Think we good now. Ill ripple the changeset stuff into those other 2 repo's also. Ill see if we can monorepo them too.

With respects to changeset, yeah that bot is just reminding you that this PR won't release anything.

That being said though, maybe we can stage push up a patch to get the readme to also update within NPM? Or do we wait for a few more features/fixes to land?

@stefcameron
Copy link
Member Author

@maraisr I like the idea of adding Changesets to those two other repos! I see David moved them over earlier today, so you should be able to set that up now.

That's true about the README in NPM. Perhaps that warrants a patch. Would be a good excuse for me to see what the full Changesets process is like, so I'll add a Changeset to this PR before I merge it so we can do a patch!

@stefcameron
Copy link
Member Author

I'm open to monorepo for the 3 of them as well, but fine to leave them as-is too. Whatever is simplest.

@stefcameron
Copy link
Member Author

@maraisr Changeset added!

@stefcameron
Copy link
Member Author

I assume we're good to go here. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeking co-maintainers!
2 participants