-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDGEPATRON-131]-Added POST edge api for LOC patron #113
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1e30414
[EDGEPATRON-131]-Added POST edge api for LOC patron
SinghAdes eff7622
Merge branch 'master' into EDGEPATRON-131
SinghAdes 06eaacc
[EDGEPATRON-131]-Added POST edge api for LOC patron
SinghAdes eca6547
Merge remote-tracking branch 'origin/EDGEPATRON-131' into EDGEPATRON-131
SinghAdes bd540eb
[EDGEPATRON-131]-Added POST edge api for LOC patron
SinghAdes 97badb6
[EDGEPATRON-131]-Added POST edge api for LOC patron
SinghAdes c888c11
[EDGEPATRON-131]-Added POST edge api for LOC patron
SinghAdes edb3daf
[EDGEPATRON-131]-Added POST edge api for LOC patron
SinghAdes 289074d
[EDGEPATRON-131]-Added POST edge api for LOC patron
SinghAdes 33ab6b7
[EDGEPATRON-131]-Added POST edge api for LOC patron
SinghAdes 681e529
[EDGEPATRON-131]-Added POST edge api for LOC patron
SinghAdes 479bbfe
[EDGEPATRON-131]-Added POST edge api for LOC patron
SinghAdes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ | |
"requires": [ | ||
{ | ||
"id": "patron", | ||
"version": "4.2 5.1" | ||
"version": "4.2 5.2" | ||
}, | ||
{ | ||
"id": "circulation", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
{ | ||
"generalInfo": { | ||
"externalSystemId": "ext-123456", | ||
"firstName": "John", | ||
"preferredFirstName": "Johnny", | ||
"middleName": "M", | ||
"lastName": "Doe" | ||
}, | ||
"address0": { | ||
"addressLine0": "123 Main St", | ||
"addressLine1": "Apt 4B", | ||
"city": "Metropolis", | ||
"province": "NY", | ||
"zip": "12345", | ||
"country": "USA" | ||
}, | ||
"address1": { | ||
"addressLine0": "456 Side St", | ||
"addressLine1": "Suite 500", | ||
"city": "Metropolis", | ||
"province": "NY", | ||
"zip": "12346", | ||
"country": "USA" | ||
}, | ||
"contactInfo": { | ||
"phone": "555-1234", | ||
"mobilePhone": "555-5678", | ||
"email": "john.doe@example.com" | ||
}, | ||
"preferredEmailCommunication": ["Support", "Programs"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,135 @@ | ||
{ | ||
"$schema": "http://json-schema.org/draft-04/schema#", | ||
"title": "User Information Schema", | ||
"description": "Schema for user information including general info, addresses, contact info", | ||
"type": "object", | ||
"properties": { | ||
"generalInfo": { | ||
"type": "object", | ||
"description": "General info of patron", | ||
"properties": { | ||
"externalSystemId": { | ||
"type": "string", | ||
"description": "A unique ID that corresponds to an external authority" | ||
}, | ||
"firstName": { | ||
"type": "string", | ||
"description": "The user's given name" | ||
}, | ||
"preferredFirstName": { | ||
"type": "string", | ||
"description": "The user's preferred name" | ||
}, | ||
"middleName": { | ||
"type": "string", | ||
"description": "The user's middle name (if any)" | ||
}, | ||
"lastName": { | ||
"type": "string", | ||
"description": "The user's surname" | ||
} | ||
}, | ||
"required": ["externalSystemId", "firstName", "lastName"], | ||
"additionalProperties": false | ||
}, | ||
"address0": { | ||
"type": "object", | ||
"description": "Primary address info of patron", | ||
"properties": { | ||
"addressLine0": { | ||
"type": "string", | ||
"description": "Address, Line 0" | ||
}, | ||
"addressLine1": { | ||
"type": "string", | ||
"description": "Address, Line 1" | ||
}, | ||
"city": { | ||
"type": "string", | ||
"description": "City name" | ||
}, | ||
"province": { | ||
"type": "string", | ||
"description": "Province" | ||
}, | ||
"zip": { | ||
"type": "string", | ||
"description": "Zip Code" | ||
}, | ||
"country": { | ||
"type": "string", | ||
"description": "Country" | ||
} | ||
}, | ||
"required": ["addressLine0", "city", "province", "zip", "country"], | ||
"additionalProperties": false | ||
}, | ||
"address1": { | ||
"type": "object", | ||
"description": "Secondary address info of patron", | ||
"properties": { | ||
"addressLine0": { | ||
"type": "string", | ||
"description": "Address, Line 0" | ||
}, | ||
"addressLine1": { | ||
"type": "string", | ||
"description": "Address, Line 1" | ||
}, | ||
"city": { | ||
"type": "string", | ||
"description": "City name" | ||
}, | ||
"province": { | ||
"type": "string", | ||
"description": "Province" | ||
}, | ||
"zip": { | ||
"type": "string", | ||
"description": "Zip Code" | ||
}, | ||
"country": { | ||
"type": "string", | ||
"description": "Country" | ||
} | ||
}, | ||
"required": ["addressLine0", "city", "province", "zip", "country"], | ||
"additionalProperties": false | ||
}, | ||
"contactInfo": { | ||
"type": "object", | ||
"description": "Contact info of patron", | ||
"properties": { | ||
"phone": { | ||
"type": "string", | ||
"description": "The user's primary phone number" | ||
}, | ||
"mobilePhone": { | ||
"type": "string", | ||
"description": "The user's mobile phone number" | ||
}, | ||
"email": { | ||
"type": "string", | ||
"description": "The user's email address", | ||
"format": "email" | ||
} | ||
}, | ||
"required": ["email"], | ||
"additionalProperties": false | ||
}, | ||
"preferredEmailCommunication": { | ||
"type": "array", | ||
"description": "Email communication info of patron", | ||
"items": { | ||
"type": "string", | ||
"enum": ["Support", "Programs", "Service"] | ||
}, | ||
"minItems": 1, | ||
"maxItems": 3, | ||
"uniqueItems": true, | ||
"description": "Preferred email communication types" | ||
} | ||
}, | ||
"required": ["generalInfo", "address0", "contactInfo", "preferredEmailCommunication"], | ||
"additionalProperties": false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the use of new condition here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vignesh-kalyanasundaram :- just as precaution , There might be a case when we receive an empty or null response from mod-patron. in this case this code will not fail as NullPointer exception .