Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot browserify demo after clone #230

Closed
startswithaj opened this issue May 3, 2014 · 3 comments
Closed

Cannot browserify demo after clone #230

startswithaj opened this issue May 3, 2014 · 3 comments

Comments

@startswithaj
Copy link

Heya,

I've been trying to browserify pdfkit for the last couple of hours have continually been running into the problem

SyntaxError: Line 11: Unexpected identifier while parsing /Users/blah/pdfkit/js/document.js

So I thought I should clone this repo and try and build the demo bundle the same way the make file does. I still get the error. I made sure that I'm using the version of browserify - 3.39.0
I still get

./node_modules/.bin/browserify demo/browser.js > demo/bundle.js
SyntaxError: Line 11: Unexpected identifier while parsing /Users/blah/pdfkit/js/document.js

It's driving me crazy. Any help would be appreciated

@startswithaj
Copy link
Author

make browser-demo
./node_modules/.bin/browserify demo/browser.js > demo/bundle.js
SyntaxError: Line 11: Unexpected identifier while parsing /Users/Jake/dev/pdfkit/js/document.js
make: *** [browser-demo] Error 1

@startswithaj
Copy link
Author

It's caused by brfs version 1.1.1
I rolled back to brfs 1.0.1, recompiled the javascript and then browserified it and all was well

ryanwersal added a commit to ZuercherTech/pdfkit that referenced this issue May 6, 2014
Restrict brfs' version to fix expected identifier errors. See foliojs#230.
Add blob-stream as a dependency.
ryanwersal added a commit to ZuercherTech/pdfkit that referenced this issue May 6, 2014
Restrict brfs' version to fix unexpected identifier errors. See foliojs#230.
Add blob-stream as a dependency.
@devongovett
Copy link
Member

Should be fixed by #234.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants