Fix dependencies for browser-demo #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restrict brfs' version to fix unexpected identifier errors. See foliojs#230. Add blob-stream as a dependency.
| "exorcist": "^0.1.5", | ||
| "brace": "^0.2.1" | ||
| }, | ||
| "dependencies": { | ||
| "png-js": ">=0.1.0", | ||
| "linebreak": "~0.1.0" | ||
| "linebreak": "~0.1.0", | ||
| "blob-stream": "^0.1.2" |
There was a problem hiding this comment.
Should be a dev dependency. PDFKit itself does not depend on blob-stream, it is just used for the demos.
There was a problem hiding this comment.
Fixed. Sorry about that.
devongovett
added a commit
that referenced
this pull request
May 6, 2014
Fix dependencies for browser-demo
|
Thanks for the fix! |
|
@ryanwersal out of interest did you figure out what was changing in brfs that was causing it to break? |
|
@startswithaj Nope, I did not investigate into why it was breaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict brfs' version to fix unexpected identifier errors. See #230.
Add blob-stream as a dependency.
This fixes a couple minor issues I ran into regarding the dependencies for the browser-demo.