Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 166/165 Add CAS1 element & reorganise aircrew classes #189

Closed
wants to merge 4 commits into from

Conversation

shadow-fa
Copy link
Collaborator

@shadow-fa shadow-fa commented Oct 6, 2018

This PR resolves the isues #166 and #165.

Changes:

  • Add CAS1 element
  • Add backpack and toolkit to jet loadouts
  • Consolidate pilot classes ("pc","pcc","pp") into a single Helicopter Crew class ("pc").
  • Remove old _bagmedium variable which does not exist anymore

It probably makes sense to merge #191 (and #185) first, and then I will re-do this PR so that it is auto-mergeable.
Or i can move these changes directly into #191.
(#185 already handles group ID and group markers for CAS1)

@NikkoJT
Copy link
Collaborator

NikkoJT commented Oct 7, 2018

Does this also add a jet pilot class with the jet pilot helmet and the engineer trait? That being the other goal of #165 .

@shadow-fa
Copy link
Collaborator Author

Yes.
Feel free to download that branch and test it locally to see if everything is as expected.

@shadow-fa
Copy link
Collaborator Author

Closing in favor of #191 and #185.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants