Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: transparent = true not working #561

Closed
3 tasks done
nduartech opened this issue Jul 2, 2024 · 3 comments · Fixed by #632
Closed
3 tasks done

bug: transparent = true not working #561

nduartech opened this issue Jul 2, 2024 · 3 comments · Fixed by #632
Labels
bug Something isn't working

Comments

@nduartech
Copy link

Did you check docs and existing issues?

  • I have read all the tokyonight.nvim docs
  • I have searched the existing issues of tokyonight.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.10.0

Operating system/version

Ubuntu

Describe the bug

Setting transparent = true doesn't work in latest update

Steps To Reproduce

  1. Set transparent = true
  2. Have version latest of tokyonight

Expected Behavior

Bg should become transparent, it works when I roll back to 4.1.0 btw

Repro

No response
@nduartech nduartech added the bug Something isn't working label Jul 2, 2024
@nduartech nduartech closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
@dkarter
Copy link

dkarter commented Jul 3, 2024 •
edited
Loading

@nduartech I'm seeing this too, did you mean to close the issue?

@PhilStar101
Copy link

@dkarter @nduartech I found that this behavior can be caused by cache. When i set cache to false it works!

@massimans
Copy link
Contributor

had this too, i investigated a bit and it seems that changing transparent value doesn't invalidate the cache

@massimans massimans mentioned this issue Sep 10, 2024
Merged
folke pushed a commit that referenced this issue Sep 16, 2024
@massimans
fix(groups): changing the transparent option now correctly invalidate…
f31be07 
…s the cache (#632)

## Description
this PR fixes the issue where changing "transparent" option wasn't taken
into account when cache was active due to cache not being invalidated
properly for "transparent" value changes.

## Related Issue(s)


  - Fixes #561

Co-authored-by: Massinissa Mansouri <massinissa.mansouri@outlook.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@dkarter @massimans @nduartech @PhilStar101