Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(groups): changing the transparent option now correctly invalidates the cache #632

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

massimans
Copy link
Contributor

Description

this PR fixes the issue where changing "transparent" option wasn't taken into account when cache was active due to cache not being invalidated properly for "transparent" value changes.

Related Issue(s)

@massimans massimans changed the title fix: changing the transparent option now correctly invalidates the cache fix(base): changing the transparent option now correctly invalidates the cache Sep 10, 2024
@massimans massimans changed the title fix(base): changing the transparent option now correctly invalidates the cache fix(groups): changing the transparent option now correctly invalidates the cache Sep 10, 2024
@folke folke merged commit f31be07 into folke:main Sep 16, 2024
10 of 11 checks passed
@folke
Copy link
Owner

folke commented Sep 16, 2024

ty!

patnr added a commit to patnr/tokyonight.nvim that referenced this pull request Sep 26, 2024
* upstream/main:
  chore(build): auto-generate docs
  feat(supermaven): add support for supermaven-nvim (folke#633)
  fix(groups): changing the transparent option now correctly invalidates the cache (folke#632)
folke pushed a commit that referenced this pull request Oct 23, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.9.0](v4.8.0...v4.9.0)
(2024-10-23)


### Features

* **extras:** add eza theme
([#643](#643))
([c426aeb](c426aeb))
* **extras:** add termux colors
([#645](#645))
([de09580](de09580))
* **extras:** added Ghostty themes
([c805eb8](c805eb8))
* **supermaven:** add support for supermaven-nvim
([#633](#633))
([9699675](9699675))
* **terminal:** bright ansi colors
([#648](#648))
([5e64b21](5e64b21))


### Bug Fixes

* **groups:** changing the transparent option now correctly invalidates
the cache ([#632](#632))
([f31be07](f31be07))
* **mini_tabline:** make MiniTablineTabpagesection more visible
([#621](#621))
([b329f4f](b329f4f))
* **terminal:** assign magenta to correct terminal color
([#640](#640))
([cc0e0e2](cc0e0e2))
* **tmux:** use 24h format
([#624](#624))
([65837cc](65837cc))
* **which-key:** delete duplicate WhichKeySeparator group
([#639](#639))
([63e5f2e](63e5f2e))
* **zathura:** highlight transparency
([#638](#638))
([b6d01e7](b6d01e7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: transparent = true not working
2 participants