fix(form): action input had wrong border radius in some cases #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
ColinFrick,
y0hami,
lubber-de and
prudho
exoego
changed the title
lubber-de
requested changes
Nov 27, 2019
There was a problem hiding this comment.
Please also support a possible left action
See https://jsfiddle.net/knr2xw71/
Right borders in left action inputs are also not rounded anymore when focussed
lubber-de
added
state/awaiting-reviews
|
@lubber-de |
exoego
changed the title
prudho
reviewed
Dec 6, 2019
ColinFrick
approved these changes
Dec 11, 2019
|
@exoego I update your jsfiddle to see this case : https://jsfiddle.net/dutrieux/4ets2cgm/ |
|
@dutrieux My first feeling is that the issue you mentioned looks complicated and may require a lot effort, so should be addressed in different PR. |
y0hami
changed the title
lubber-de
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.ui.inputin.ui.formhas border-radius at all corners.Fomantic-UI/src/definitions/collections/form.less
Line 411 in 2f3312f
Unfortunately, this override brings border-radius to
.ui.action.input.This PR removes border-radius from
.ui.action.inputin.ui.formwhere radius not needed.Testcase
https://jsfiddle.net/qdp6gxLy/1/
Screenshot (when possible)
Closes
#1184
#1185