fix(themes): use only woff files and fix firefox font line gap warning #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
This was referenced Oct 3, 2022
|
I am very sorry, the |
Doesnt matter. THiS PR is still valid in case of not using ttf/eot/svg anymore. i'll adjust the PR description |
mvorisek
reviewed
Oct 3, 2022
fixes fomantic#2478 How the PR was made: 1. data URIs were saved into files: - [DropdownFont.woff](https://github.com/lubber-de/Fomantic-UI/files/9696395/DropdownFont.woff.zip) - [CheckboxFont.woff](https://github.com/lubber-de/Fomantic-UI/files/9696397/CheckboxFont.woff.zip) - [AccordionFont.woff](https://github.com/lubber-de/Fomantic-UI/files/9696398/AccordionFont.woff.zip) - [StepFont.woff](https://github.com/lubber-de/Fomantic-UI/files/9696400/StepFont.woff.zip) - [DocsFont.woff](https://github.com/lubber-de/Fomantic-UI/files/9696693/DocsFont.woff.zip) 2. open with FontForge editor note `Step` file (only this one file) has shown  on open - no action taken   3. show only available glyphs Encoding menu -> Compact (hide unused glyphs) 4. change Element menu -> Font Info -> OS/2 -> Metrics tab -> Typo Line Gap from `-32` to `0`, according to https://www.high-logic.com/fontcreator/manual11/properties-metrics.html it is MacOS specific setting and > Negative Line Gap values are treated as zero. this statement is consistent with Firefox message and behaviour 5. save it File menu -> Generate Fonts... -> save as WOFF when exporting `Step` font, the following shown  I changed the size from 1000 to 1024 6. convert back to data URI with https://base64.guru/converter/encode/file and commit
lubber-de
changed the title
lubber-de
changed the title
lubber-de
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As woff files are supported everwhere since IE11, i removed all eot,ttf,svg files and their references. Also adjusted some according theme references to match the new LESS-map icon generation
This PR also adjusts the negativ linegap issue. Thanks to @mvorisek which kindly added his fixes into this PR directly via lubber-de#51
Closes
#2478
#1254
Semantic-Org/Semantic-UI#2146