fix(chore): font negative line gap to avoid firefox warning #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is done and targetting fomantic#2480, feel free to squash the changes before merge (can be done easily via GH UI when merging) |
lubber-de
approved these changes
Oct 3, 2022
|
For reference, her is a jsfiddle to test the changes. Everything looks as before 🙂 Only the firefox warning is gone. |
lubber-de
changed the title
lubber-de
added a commit
to fomantic/Fomantic-UI
that referenced
this pull request
Oct 4, 2022
As woff files are supported everwhere since IE11, i removed all eot,ttf,svg files and their references. Also adjusted some according theme references to match the new LESS-map icon generation This PR also adjusts the negativ linegap issue. Thanks to @mvorisek which kindly added his fixes into this PR directly via lubber-de#51 Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes fomantic#2478
How the PR was made:
data URIs were saved into files:
open with FontForge editor
note
Stepfile (only this one file) has shownon open - no action taken
show only available glyphs Encoding menu -> Compact (hide unused glyphs)
change Element menu -> Font Info -> OS/2 -> Metrics tab -> Typo Line Gap from
-32to0, according to https://www.high-logic.com/fontcreator/manual11/properties-metrics.html it is MacOS specific setting andsave it File menu -> Generate Fonts... -> save as WOFF
when exporting
Stepfont, the following shownI changed the size from 1000 to 1024
convert back to data URI with https://base64.guru/converter/encode/file and commit