Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lint): add stylelint for LESS and normalize whitespaces #2592

Merged
merged 28 commits into from
Dec 9, 2022
Merged

feat(lint): add stylelint for LESS and normalize whitespaces #2592

merged 28 commits into from
Dec 9, 2022

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Dec 9, 2022 •
edited
Loading

Like #2501, but for LESS. No functionality change.

@mvorisek mvorisek marked this pull request as draft December 9, 2022 15:54
@mvorisek mvorisek changed the title Add Stylelint CSS/LESS linter and unify indent Add Stylelint linter for LESS and unify indent Dec 9, 2022
@mvorisek mvorisek changed the title Add Stylelint linter for LESS and unify indent Add Stylelint linter for LESS and unify whitespaces Dec 9, 2022
@mvorisek mvorisek changed the title Add Stylelint linter for LESS and unify whitespaces Add Stylelint linter for LESS and normalize whitespaces Dec 9, 2022
@mvorisek mvorisek marked this pull request as ready for review December 9, 2022 20:39
@mvorisek
Copy link
Contributor Author

mvorisek commented Dec 9, 2022

This PR is complete, hash of (newly built) semantic.min.css is the same as before these changes.

lubber-de
lubber-de reviewed Dec 9, 2022
View reviewed changes
.eslintrc.js Show resolved Hide resolved
lubber-de
lubber-de reviewed Dec 9, 2022
View reviewed changes
package.json Show resolved Hide resolved
lubber-de
lubber-de approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de changed the title Add Stylelint linter for LESS and normalize whitespaces feat(lint): add stylelint for LESS and normalize whitespaces Dec 9, 2022
@lubber-de lubber-de merged commit d4987bf into fomantic:develop Dec 9, 2022
@lubber-de lubber-de added lang/css Anything involving CSS type/build Anything related to the build process type/chore Anything which is a project chore type/ci Anything related to CI/CD labels Dec 9, 2022
@lubber-de lubber-de added this to the 2.9.1 milestone Dec 9, 2022
@mvorisek mvorisek deleted the add_stylelint branch December 9, 2022 23:23
@mvorisek mvorisek mentioned this pull request Dec 10, 2022
Merged
lubber-de pushed a commit that referenced this pull request Dec 10, 2022
@mvorisek
feat(lint): add stylelint overrides and variation files
ce26829 
In #2592 I completely missed there are also LESS files named with *.overrides and *.variables extensions, so these LESS files are fixed in this PR. As in #2592, only whitespaces are fixed, no functional change.
@lubber-de lubber-de added the type/lint eslint / stylelint related changes only label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@exoego exoego Awaiting requested review from exoego

@y0hami y0hami Awaiting requested review from y0hami

@ko2in ko2in Awaiting requested review from ko2in

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/build Anything related to the build process type/chore Anything which is a project chore type/ci Anything related to CI/CD type/lint eslint / stylelint related changes only
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @lubber-de